From: Jeff Garzik <jeff@garzik.org>
To: chas williams - CONTRACTOR <chas@cmf.nrl.navy.mil>,
Netdev List <netdev@vger.kernel.org>
Cc: Andrew Morton <akpm@osdl.org>
Subject: ATM firestream bug
Date: Sun, 01 Oct 2006 10:45:40 -0400 [thread overview]
Message-ID: <451FD494.1090804@garzik.org> (raw)
The gcc warning "may be used uninitialized" is correct here, as well:
drivers/atm/firestream.c: In function ‘top_off_fp’:
drivers/atm/firestream.c:1501: warning: cast to pointer from integer of
different size
drivers/atm/firestream.c: In function ‘fs_open’:
drivers/atm/firestream.c:870: warning: ‘tmc0’ may be used uninitialized
in this function
This indicates two bugs:
1) not safe on 64-bit
2) variable 'tmc0' is indeed potentially used uninit'd, in particular if
make_rate() returns an error (use occurs before error check).
next reply other threads:[~2006-10-01 14:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-01 14:45 Jeff Garzik [this message]
2006-10-01 15:10 ` ATM firestream bug Mitchell Blank Jr
2006-10-01 16:56 ` chas williams - CONTRACTOR
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=451FD494.1090804@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@osdl.org \
--cc=chas@cmf.nrl.navy.mil \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).