From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-180.mta0.migadu.com (out-180.mta0.migadu.com [91.218.175.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E63425A645 for ; Mon, 24 Feb 2025 16:05:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740413161; cv=none; b=pWspKWdg9of8DHuD+ZK2z2afHWzqCrJ3cvtv9nT2u1snU4vUfGgwqmdyTdaRfCEPwhOpKKlayatrbquUVBkiMK9FJAjgYh3vC7H2VCnBSVIuj1OexliJ7fqBdhPoegmIvjrRxuGjyXCUgfhmaZEQ2MpVcpyshNKmzRt75ZcblyE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740413161; c=relaxed/simple; bh=qld9vDpB6QDXxnS+8fXAONoUc5F9WAZoTYNAokUyWH0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=g9oignks2jOmycnfRhhVvOix58v8in3KGn19uk8hETSqfWNYlBDAy1pJojFmNnsAdoru/jewyORKbn6DAF90JlfGqVla6ZmokopgKCSEmZBL/QgISAZ8c2HcnsPVh2TIRYsN/43ly4xq04nBuvqXpMByv/ClzuSoCV1y0P4FPA0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=lQG+gacF; arc=none smtp.client-ip=91.218.175.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="lQG+gacF" Message-ID: <451d4cfe-b22f-4ac5-9074-05a2155f7d6a@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1740413146; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D1Rbf9tEpuTcSX5Ha3F0jZOYLk78dDb108drquGs+dE=; b=lQG+gacFqb/aKv2uO2khuC+L2k+vkY9QlpGyXc62KwxI2OSsFuUymwrKqnb/I9zXitLs/+ fUBjZLpNErr4kj9pxxcb8J9DOCaGDHYvRplfSXaffdSe+BSeR03M3qth3/mk4355HMqy5j dsJRLwP2e4dzE0SzpWG4K+m2VT3bQGs= Date: Mon, 24 Feb 2025 16:05:43 +0000 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH] net: wangxun: fix LIBWX dependencies To: Arnd Bergmann , Jiawen Wu , Mengyuan Lou , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Richard Cochran Cc: Arnd Bergmann , Heikki Krogerus , Jarkko Nikula , Andi Shyti , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250224140516.1168214-1-arnd@kernel.org> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: <20250224140516.1168214-1-arnd@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 24/02/2025 14:05, Arnd Bergmann wrote: > From: Arnd Bergmann > > Selecting LIBWX requires that its dependencies are met first: > > WARNING: unmet direct dependencies detected for LIBWX > Depends on [m]: NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_WANGXUN [=y] && PTP_1588_CLOCK_OPTIONAL [=m] > Selected by [y]: > - TXGBE [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_WANGXUN [=y] && PCI [=y] && COMMON_CLK [=y] && I2C_DESIGNWARE_PLATFORM [=y] > ld.lld-21: error: undefined symbol: ptp_schedule_worker >>>> referenced by wx_ptp.c:747 (/home/arnd/arm-soc/drivers/net/ethernet/wangxun/libwx/wx_ptp.c:747) >>>> drivers/net/ethernet/wangxun/libwx/wx_ptp.o:(wx_ptp_reset) in archive vmlinux.a > > Add the smae dependency on PTP_1588_CLOCK_OPTIONAL to the two driver > using this library module. > > Fixes: 06e75161b9d4 ("net: wangxun: Add support for PTP clock") > Signed-off-by: Arnd Bergmann > --- > drivers/net/ethernet/wangxun/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ethernet/wangxun/Kconfig b/drivers/net/ethernet/wangxun/Kconfig > index 6b60173fe1f5..47e3e8434b9e 100644 > --- a/drivers/net/ethernet/wangxun/Kconfig > +++ b/drivers/net/ethernet/wangxun/Kconfig > @@ -26,6 +26,7 @@ config LIBWX > config NGBE > tristate "Wangxun(R) GbE PCI Express adapters support" > depends on PCI > + depends on PTP_1588_CLOCK_OPTIONAL > select LIBWX > select PHYLINK > help > @@ -43,6 +44,7 @@ config TXGBE > depends on PCI > depends on COMMON_CLK > depends on I2C_DESIGNWARE_PLATFORM > + depends on PTP_1588_CLOCK_OPTIONAL > select MARVELL_10G_PHY > select REGMAP > select PHYLINK Reviewed-by: Vadim Fedorenko