* [PATCH] net: wangxun: fix LIBWX dependencies
@ 2025-02-24 14:05 Arnd Bergmann
2025-02-24 16:05 ` Vadim Fedorenko
2025-02-26 3:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2025-02-24 14:05 UTC (permalink / raw)
To: Jiawen Wu, Mengyuan Lou, Andrew Lunn, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Richard Cochran,
Vadim Fedorenko
Cc: Arnd Bergmann, Heikki Krogerus, Jarkko Nikula, Andi Shyti, netdev,
linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Selecting LIBWX requires that its dependencies are met first:
WARNING: unmet direct dependencies detected for LIBWX
Depends on [m]: NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_WANGXUN [=y] && PTP_1588_CLOCK_OPTIONAL [=m]
Selected by [y]:
- TXGBE [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_WANGXUN [=y] && PCI [=y] && COMMON_CLK [=y] && I2C_DESIGNWARE_PLATFORM [=y]
ld.lld-21: error: undefined symbol: ptp_schedule_worker
>>> referenced by wx_ptp.c:747 (/home/arnd/arm-soc/drivers/net/ethernet/wangxun/libwx/wx_ptp.c:747)
>>> drivers/net/ethernet/wangxun/libwx/wx_ptp.o:(wx_ptp_reset) in archive vmlinux.a
Add the smae dependency on PTP_1588_CLOCK_OPTIONAL to the two driver
using this library module.
Fixes: 06e75161b9d4 ("net: wangxun: Add support for PTP clock")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/ethernet/wangxun/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/wangxun/Kconfig b/drivers/net/ethernet/wangxun/Kconfig
index 6b60173fe1f5..47e3e8434b9e 100644
--- a/drivers/net/ethernet/wangxun/Kconfig
+++ b/drivers/net/ethernet/wangxun/Kconfig
@@ -26,6 +26,7 @@ config LIBWX
config NGBE
tristate "Wangxun(R) GbE PCI Express adapters support"
depends on PCI
+ depends on PTP_1588_CLOCK_OPTIONAL
select LIBWX
select PHYLINK
help
@@ -43,6 +44,7 @@ config TXGBE
depends on PCI
depends on COMMON_CLK
depends on I2C_DESIGNWARE_PLATFORM
+ depends on PTP_1588_CLOCK_OPTIONAL
select MARVELL_10G_PHY
select REGMAP
select PHYLINK
--
2.39.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net: wangxun: fix LIBWX dependencies
2025-02-24 14:05 [PATCH] net: wangxun: fix LIBWX dependencies Arnd Bergmann
@ 2025-02-24 16:05 ` Vadim Fedorenko
2025-02-26 3:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Vadim Fedorenko @ 2025-02-24 16:05 UTC (permalink / raw)
To: Arnd Bergmann, Jiawen Wu, Mengyuan Lou, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Richard Cochran
Cc: Arnd Bergmann, Heikki Krogerus, Jarkko Nikula, Andi Shyti, netdev,
linux-kernel
On 24/02/2025 14:05, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Selecting LIBWX requires that its dependencies are met first:
>
> WARNING: unmet direct dependencies detected for LIBWX
> Depends on [m]: NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_WANGXUN [=y] && PTP_1588_CLOCK_OPTIONAL [=m]
> Selected by [y]:
> - TXGBE [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_WANGXUN [=y] && PCI [=y] && COMMON_CLK [=y] && I2C_DESIGNWARE_PLATFORM [=y]
> ld.lld-21: error: undefined symbol: ptp_schedule_worker
>>>> referenced by wx_ptp.c:747 (/home/arnd/arm-soc/drivers/net/ethernet/wangxun/libwx/wx_ptp.c:747)
>>>> drivers/net/ethernet/wangxun/libwx/wx_ptp.o:(wx_ptp_reset) in archive vmlinux.a
>
> Add the smae dependency on PTP_1588_CLOCK_OPTIONAL to the two driver
> using this library module.
>
> Fixes: 06e75161b9d4 ("net: wangxun: Add support for PTP clock")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/net/ethernet/wangxun/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/wangxun/Kconfig b/drivers/net/ethernet/wangxun/Kconfig
> index 6b60173fe1f5..47e3e8434b9e 100644
> --- a/drivers/net/ethernet/wangxun/Kconfig
> +++ b/drivers/net/ethernet/wangxun/Kconfig
> @@ -26,6 +26,7 @@ config LIBWX
> config NGBE
> tristate "Wangxun(R) GbE PCI Express adapters support"
> depends on PCI
> + depends on PTP_1588_CLOCK_OPTIONAL
> select LIBWX
> select PHYLINK
> help
> @@ -43,6 +44,7 @@ config TXGBE
> depends on PCI
> depends on COMMON_CLK
> depends on I2C_DESIGNWARE_PLATFORM
> + depends on PTP_1588_CLOCK_OPTIONAL
> select MARVELL_10G_PHY
> select REGMAP
> select PHYLINK
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net: wangxun: fix LIBWX dependencies
2025-02-24 14:05 [PATCH] net: wangxun: fix LIBWX dependencies Arnd Bergmann
2025-02-24 16:05 ` Vadim Fedorenko
@ 2025-02-26 3:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-02-26 3:10 UTC (permalink / raw)
To: Arnd Bergmann
Cc: jiawenwu, mengyuanlou, andrew+netdev, davem, edumazet, kuba,
pabeni, richardcochran, vadim.fedorenko, arnd, heikki.krogerus,
jarkko.nikula, andi.shyti, netdev, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 24 Feb 2025 15:05:06 +0100 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Selecting LIBWX requires that its dependencies are met first:
>
> WARNING: unmet direct dependencies detected for LIBWX
> Depends on [m]: NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_WANGXUN [=y] && PTP_1588_CLOCK_OPTIONAL [=m]
> Selected by [y]:
> - TXGBE [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_WANGXUN [=y] && PCI [=y] && COMMON_CLK [=y] && I2C_DESIGNWARE_PLATFORM [=y]
> ld.lld-21: error: undefined symbol: ptp_schedule_worker
> >>> referenced by wx_ptp.c:747 (/home/arnd/arm-soc/drivers/net/ethernet/wangxun/libwx/wx_ptp.c:747)
> >>> drivers/net/ethernet/wangxun/libwx/wx_ptp.o:(wx_ptp_reset) in archive vmlinux.a
>
> [...]
Here is the summary with links:
- net: wangxun: fix LIBWX dependencies
https://git.kernel.org/netdev/net-next/c/8fa19c2c69fb
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-02-26 3:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-24 14:05 [PATCH] net: wangxun: fix LIBWX dependencies Arnd Bergmann
2025-02-24 16:05 ` Vadim Fedorenko
2025-02-26 3:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).