* [PATCH] b44: fix multicast with >32 groups
@ 2006-09-29 21:53 Bill Helfinstine
2006-10-04 19:32 ` Gary Zambrano
2006-10-05 11:06 ` Jeff Garzik
0 siblings, 2 replies; 3+ messages in thread
From: Bill Helfinstine @ 2006-09-29 21:53 UTC (permalink / raw)
To: zambrano, netdev, jeff; +Cc: bhelf
The b44 driver has a bug where if there are more than B44_MCAST_TABLE_SIZE
groups in the dev->mc_list, it will only listen to the first
B44_MCAST_TABLE_SIZE that it sees.
This patch makes the driver go into RXCONFIG_ALLMULTI mode if there are more
than B44_MCAST_TABLE_SIZE groups being subscribed to.
This patch is against 2.6.18, b44.c version 1.01.
Signed-off-by: Bill Helfinstine <bhelf@flitterfly.whirpon.com>
diff --git a/drivers/net/b44.c b/drivers/net/b44.c
index e891ea2..dd024e1 100644
--- a/drivers/net/b44.c
+++ b/drivers/net/b44.c
@@ -1706,7 +1706,8 @@ static void __b44_set_rx_mode(struct net
__b44_set_mac_addr(bp);
- if (dev->flags & IFF_ALLMULTI)
+ if ((dev->flags & IFF_ALLMULTI) ||
+ (dev->mc_count > B44_MCAST_TABLE_SIZE))
val |= RXCONFIG_ALLMULTI;
else
i = __b44_load_mcast(bp, dev);
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] b44: fix multicast with >32 groups
2006-09-29 21:53 [PATCH] b44: fix multicast with >32 groups Bill Helfinstine
@ 2006-10-04 19:32 ` Gary Zambrano
2006-10-05 11:06 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Gary Zambrano @ 2006-10-04 19:32 UTC (permalink / raw)
To: Bill Helfinstine; +Cc: netdev, jeff
On Fri, 2006-09-29 at 17:53 -0400, Bill Helfinstine wrote:
> The b44 driver has a bug where if there are more than B44_MCAST_TABLE_SIZE
> groups in the dev->mc_list, it will only listen to the first
> B44_MCAST_TABLE_SIZE that it sees.
>
> This patch makes the driver go into RXCONFIG_ALLMULTI mode if there are more
> than B44_MCAST_TABLE_SIZE groups being subscribed to.
>
> This patch is against 2.6.18, b44.c version 1.01.
>
>
> Signed-off-by: Bill Helfinstine <bhelf@flitterfly.whirpon.com>
>
> diff --git a/drivers/net/b44.c b/drivers/net/b44.c
> index e891ea2..dd024e1 100644
> --- a/drivers/net/b44.c
> +++ b/drivers/net/b44.c
> @@ -1706,7 +1706,8 @@ static void __b44_set_rx_mode(struct net
>
> __b44_set_mac_addr(bp);
>
> - if (dev->flags & IFF_ALLMULTI)
> + if ((dev->flags & IFF_ALLMULTI) ||
> + (dev->mc_count > B44_MCAST_TABLE_SIZE))
> val |= RXCONFIG_ALLMULTI;
> else
> i = __b44_load_mcast(bp, dev);
>
It looks good to me, however, I'll have to nack it as this patch has spaces and will not apply.
Please convert the spaces to tabs.
Thanks,
Gary
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] b44: fix multicast with >32 groups
2006-09-29 21:53 [PATCH] b44: fix multicast with >32 groups Bill Helfinstine
2006-10-04 19:32 ` Gary Zambrano
@ 2006-10-05 11:06 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2006-10-05 11:06 UTC (permalink / raw)
To: Bill Helfinstine; +Cc: zambrano, netdev
Bill Helfinstine wrote:
>
> The b44 driver has a bug where if there are more than
> B44_MCAST_TABLE_SIZE groups in the dev->mc_list, it will only listen to
> the first B44_MCAST_TABLE_SIZE that it sees.
>
> This patch makes the driver go into RXCONFIG_ALLMULTI mode if there are
> more than B44_MCAST_TABLE_SIZE groups being subscribed to.
>
> This patch is against 2.6.18, b44.c version 1.01.
>
>
> Signed-off-by: Bill Helfinstine <bhelf@flitterfly.whirpon.com>
applied manually, due to whitespace damage
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-10-05 11:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-09-29 21:53 [PATCH] b44: fix multicast with >32 groups Bill Helfinstine
2006-10-04 19:32 ` Gary Zambrano
2006-10-05 11:06 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).