From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH] [TULIP] Fix section mismatch in de2104x.c Date: Fri, 06 Oct 2006 15:44:30 -0400 Message-ID: <4526B21E.8060408@garzik.org> References: <11601583542790-git-send-email-matthew@wil.cx> <20061006110317.0c6c1f98@freekitty> <4526AC09.4040804@garzik.org> <20061006192552.GM2563@parisc-linux.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Stephen Hemminger , Val Henson , netdev@vger.kernel.org, Helge Deller , Kyle McMartin Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:6057 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S932468AbWJFToy (ORCPT ); Fri, 6 Oct 2006 15:44:54 -0400 To: Matthew Wilcox In-Reply-To: <20061006192552.GM2563@parisc-linux.org> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Matthew Wilcox wrote: > On Fri, Oct 06, 2006 at 03:18:33PM -0400, Jeff Garzik wrote: >> Stephen Hemminger wrote: >>> On Fri, 06 Oct 2006 12:12:34 -0600 >>> Matthew Wilcox wrote: >>> >>>> From: Helge Deller >>>> >>>> WARNING: drivers/net/tulip/de2104x.o - Section mismatch: reference to >>>> .init.text:de_init_one from .data.rel.local after 'de_driver' (at offset >>>> 0x20) >>>> WARNING: drivers/net/tulip/de2104x.o - Section mismatch: reference to >>>> .exit.text:de_remove_one from .data.rel.local after 'de_driver' (at >>>> offset 0x28) >>> This is caused because with PCI hotplug the device might be probed after >>> the init section >>> has been removed. Ditto for remove. >> This device will never ever meet a platform where it can be hotplugged. > > According to a FreeBSD list from 1995, you could get these chips on a PCI > card from several different vendors. > > http://docs.freebsd.org/cgi/getmsg.cgi?fetch=37148+0+archive/1995/freebsd-hardware/19951001.freebsd-hardware Yes, they are ancient 32-bit PCI cards, which will never make an appearance on a PCI hotplug platform. So, it's wasteful to support hotplug in code that will never be hotplugged (as I've said for years). Jeff