From mboxrd@z Thu Jan  1 00:00:00 1970
From: Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: [patch 2/2] round_jiffies users
Date: Wed, 11 Oct 2006 01:52:23 +0200
Message-ID: <452C3237.6010708@linux.intel.com>
References: <1160496165.3000.308.camel@laptopd505.fenrus.org>	<1160496210.3000.310.camel@laptopd505.fenrus.org>	<1160496263.3000.312.camel@laptopd505.fenrus.org> <20061010154717.e2c4c149.paul@permanentmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	jgarzik@pobox.com, akpm@osdl.org, mingo@elte.hu
Return-path: <netdev-owner@vger.kernel.org>
Received: from mga07.intel.com ([143.182.124.22]:33194 "EHLO
	azsmga101.ch.intel.com") by vger.kernel.org with ESMTP
	id S932284AbWJJXwo (ORCPT <rfc822;netdev@vger.kernel.org>);
	Tue, 10 Oct 2006 19:52:44 -0400
To: Paul Dickson <paul@permanentmail.com>
In-Reply-To: <20061010154717.e2c4c149.paul@permanentmail.com>
Sender: netdev-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

Paul Dickson wrote:
> On Tue, 10 Oct 2006 18:04:23 +0200, Arjan van de Ven wrote:
> 
>> +			mod_timer(&adapter->phy_info_timer, round_jiffies(jiffies + 2 * HZ));
> 
> Shouldn't round_jiffies_relative be used for some of these, a la:
> 
>   +			mod_timer(&adapter->phy_info_timer, round_jiffies_relative(2 * HZ));
> 

mod_timer() takes an absolute jiffies value as argument, so... no :)