* Re: [PATCH] sotftmac: fix a slab corruption in WEP restricted key association
[not found] <452D6D80.3020005@free.fr>
@ 2006-10-12 0:34 ` Daniel Drake
2006-10-13 9:04 ` Johannes Berg
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Drake @ 2006-10-12 0:34 UTC (permalink / raw)
To: Laurent Riffard; +Cc: linville, netdev, johannes
Laurent Riffard wrote:
> Fix a slab corruption in ieee80211softmac_auth(). The size of a buffer
> was miscomputed.
>
> see http://bugzilla.kernel.org/show_bug.cgi?id=7245
>
> Acked-by: Daniel Drake <dsd@gentoo.org>"
> Signed-off-by: Laurent Riffard <laurent.riffard@free.fr>
Apparently the CC list didn't work out. Adding Johannes and netdev.
> net/ieee80211/softmac/ieee80211softmac_io.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6-mm/net/ieee80211/softmac/ieee80211softmac_io.c
> ===================================================================
> --- linux-2.6-mm.orig/net/ieee80211/softmac/ieee80211softmac_io.c
> +++ linux-2.6-mm/net/ieee80211/softmac/ieee80211softmac_io.c
> @@ -304,7 +304,7 @@ ieee80211softmac_auth(struct ieee80211_a
> 2 + /* Auth Transaction Seq */
> 2 + /* Status Code */
> /* Challenge Text IE */
> - is_shared_response ? 0 : 1 + 1 + net->challenge_len
> + (is_shared_response ? 1 + 1 + net->challenge_len : 0)
> );
> if (unlikely((*pkt) == NULL))
> return 0;
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] sotftmac: fix a slab corruption in WEP restricted key association
2006-10-12 0:34 ` [PATCH] sotftmac: fix a slab corruption in WEP restricted key association Daniel Drake
@ 2006-10-13 9:04 ` Johannes Berg
2006-10-13 12:08 ` Daniel Drake
0 siblings, 1 reply; 4+ messages in thread
From: Johannes Berg @ 2006-10-13 9:04 UTC (permalink / raw)
To: Daniel Drake; +Cc: Laurent Riffard, linville, netdev
On Wed, 2006-10-11 at 20:34 -0400, Daniel Drake wrote:
> > - is_shared_response ? 0 : 1 + 1 + net->challenge_len
> > + (is_shared_response ? 1 + 1 + net->challenge_len : 0)
Good catch. We should send this to -stable too I think. Mind reposting
the patch in an applicable format to Daniel, netdev, john, -stable (and
possibly me)? Quoted isn't too useful :)
Oh and you can add
Acked-by: Johannes Berg <johannes@sipsolutions.net>
johannes
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sotftmac: fix a slab corruption in WEP restricted key association
2006-10-13 9:04 ` Johannes Berg
@ 2006-10-13 12:08 ` Daniel Drake
2006-10-13 12:12 ` Johannes Berg
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Drake @ 2006-10-13 12:08 UTC (permalink / raw)
To: Johannes Berg; +Cc: Laurent Riffard, linville, netdev
Johannes Berg wrote:
> Good catch. We should send this to -stable too I think. Mind reposting
> the patch in an applicable format to Daniel, netdev, john, -stable (and
> possibly me)? Quoted isn't too useful :)
It was already sent to John directly. I was planning on sending it to
-stable as soon as it hits Linus' tree.
Daniel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sotftmac: fix a slab corruption in WEP restricted key association
2006-10-13 12:08 ` Daniel Drake
@ 2006-10-13 12:12 ` Johannes Berg
0 siblings, 0 replies; 4+ messages in thread
From: Johannes Berg @ 2006-10-13 12:12 UTC (permalink / raw)
To: Daniel Drake; +Cc: Laurent Riffard, linville, netdev
On Fri, 2006-10-13 at 08:08 -0400, Daniel Drake wrote:
> Johannes Berg wrote:
> > Good catch. We should send this to -stable too I think. Mind reposting
> > the patch in an applicable format to Daniel, netdev, john, -stable (and
> > possibly me)? Quoted isn't too useful :)
>
> It was already sent to John directly. I was planning on sending it to
> -stable as soon as it hits Linus' tree.
Oh ok, good. Thanks.
johannes
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-10-13 12:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <452D6D80.3020005@free.fr>
2006-10-12 0:34 ` [PATCH] sotftmac: fix a slab corruption in WEP restricted key association Daniel Drake
2006-10-13 9:04 ` Johannes Berg
2006-10-13 12:08 ` Daniel Drake
2006-10-13 12:12 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).