From: Ville Nuorvala <vnuorval@tcs.hut.fi>
To: David Miller <davem@davemloft.net>
Cc: yoshfuji@linux-ipv6.org, tgraf@suug.ch, netdev@vger.kernel.org,
kim.nordlund@nokia.com
Subject: Re: [IPv6] rules: Use RT6_LOOKUP_F_HAS_SADDR and fix source based selectors
Date: Fri, 13 Oct 2006 11:58:44 +0300 [thread overview]
Message-ID: <452F5544.6080407@tcs.hut.fi> (raw)
In-Reply-To: <20061012.191630.35017097.davem@davemloft.net>
On 10/13/06 05:16, David Miller wrote:
> From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
> Date: Thu, 12 Oct 2006 18:55:51 +0900 (JST)
>
>> I tend to agree. Ville, do you agree?
>
> I'll wait for Ville's response before applying this.
> Otherwise, I think the change looks fine.
Acked-by: Ville Nuorvala <vnuorval@tcs.hut.fi>
This doesn't however solve all the problems with source address based
routing. For example we always need to have a valid source address when
we cow or copy a route in ip6_pol_route_output() etc. In my original
solution I moved the source address selection functionality into the
route lookup code as the two very much depend on each other and can't
IMO really be done separately.
I'm currently working on a patch for all of this, but please go ahead
and apply Thomas's and Kim's patch.
I'll try to post an initial RFC version of my patch later today.
Regards,
Ville
next prev parent reply other threads:[~2006-10-13 8:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-12 9:41 [IPv6] rules: Use RT6_LOOKUP_F_HAS_SADDR and fix source based selectors Thomas Graf
2006-10-12 9:55 ` YOSHIFUJI Hideaki / 吉藤英明
2006-10-13 2:16 ` David Miller
2006-10-13 8:58 ` Ville Nuorvala [this message]
2006-10-13 22:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=452F5544.6080407@tcs.hut.fi \
--to=vnuorval@tcs.hut.fi \
--cc=davem@davemloft.net \
--cc=kim.nordlund@nokia.com \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).