netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rahul Hari <rahulhsaxena@gmail.com>
To: Thomas Graf <tgraf@suug.ch>
Cc: netdev@oss.sgi.com, netdev@vger.kernel.org,
	lartc-request@mailman.ds9a.nl,
	diffserv-general@lists.sourceforge.net
Subject: Re: testing techniques to confirm the effectiveness of changes made to sch_gred.c
Date: Mon, 13 Jun 2005 01:35:01 +0530	[thread overview]
Message-ID: <4532f3170506121305327ad0f6@mail.gmail.com> (raw)
In-Reply-To: <20050612104628.GA22463@postel.suug.ch>

> > 1) Since the  process deals with dequeueing, i have to make changes to
> > gred_dequeue only. If t->tab[0] != 0 then  we dequeue the packet
> > otherwise do not dequeue it.
> 
> What you describe above is: only dequeue when DP 0 is configured,
> probably not what you want. The only way to prioritize within gred
> the way you want is to modify dequeue() that it iterates through
> sch->q looking for a skb with tcindex==DP0 and use it instead of
> the skb at the queue head.
> 
Thanks for the reply Thomas, 
by checking t->tab[0]!=0, the approach I wanted to follow was that "if
I have a packet in the virtual queue with DP 0, then I should not be
dequeuing any packets from the other virtual queues", ie, take no
action at all.

with best regards,
Rahul 
-- 
----------------------
"The fear you let build up in your mind is worse than the situation
that actually exists"
from "who moved my cheese"
---------------------------------------------------------------------------------
Rahul Hari
Senior Under Grad. Student,
Department of CSE,
ITBHU,
Varanasi.
Ph: +91-9845347020
rahul.hari@cse06.itbhu.org
------------------------------------------------------------------------------------------

      reply	other threads:[~2005-06-12 20:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-11  0:39 testing techniques to confirm the effectiveness of changes made to sch_gred.c Rahul Hari
2005-06-12 10:46 ` Thomas Graf
2005-06-12 20:05   ` Rahul Hari [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4532f3170506121305327ad0f6@mail.gmail.com \
    --to=rahulhsaxena@gmail.com \
    --cc=diffserv-general@lists.sourceforge.net \
    --cc=lartc-request@mailman.ds9a.nl \
    --cc=netdev@oss.sgi.com \
    --cc=netdev@vger.kernel.org \
    --cc=rahul.hari@cse06.itbhu.org \
    --cc=tgraf@suug.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).