* [PATCH 4/13] [IPV6] Clean up BACKTRACK().
@ 2006-10-17 0:06 Ville Nuorvala
2006-10-17 5:11 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Ville Nuorvala @ 2006-10-17 0:06 UTC (permalink / raw)
To: David S. Miller; +Cc: YOSHIFUJI Hideaki, Thomas Graf, kim.nordlund, netdev
The fn check is unnecessary as fn can never be NULL in BACKTRACK().
Signed-off-by: Ville Nuorvala <vnuorval@tcs.hut.fi>
---
net/ipv6/route.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index a1b0f07..263c057 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -484,7 +484,7 @@ #define BACKTRACK(saddr) \
do { \
if (rt == &ip6_null_entry) { \
struct fib6_node *pn; \
- while (fn) { \
+ while (1) { \
if (fn->fn_flags & RTN_TL_ROOT) \
goto out; \
pn = fn->parent; \
--
1.4.2.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 4/13] [IPV6] Clean up BACKTRACK().
2006-10-17 0:06 [PATCH 4/13] [IPV6] Clean up BACKTRACK() Ville Nuorvala
@ 2006-10-17 5:11 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2006-10-17 5:11 UTC (permalink / raw)
To: vnuorval; +Cc: yoshfuji, tgraf, kim.nordlund, netdev
From: Ville Nuorvala <vnuorval@tcs.hut.fi>
Date: Tue, 17 Oct 2006 03:06:27 +0300
> The fn check is unnecessary as fn can never be NULL in BACKTRACK().
>
> Signed-off-by: Ville Nuorvala <vnuorval@tcs.hut.fi>
Applied, especially valid since we're walking parents up to
the, we break out at hitting root, and root's parent is
itself :-)
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-10-17 5:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-17 0:06 [PATCH 4/13] [IPV6] Clean up BACKTRACK() Ville Nuorvala
2006-10-17 5:11 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).