From: Sridhar Samudrala <sri@us.ibm.com>
To: Ville Nuorvala <vnuorval@tcs.hut.fi>
Cc: "David S. Miller" <davem@davemloft.net>,
YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>,
Thomas Graf <tgraf@suug.ch>,
kim.nordlund@nokia.com, lksctp-developers@lists.sourceforge.net,
netdev@vger.kernel.org
Subject: Re: [PATCH 9/13] [SCTP] Merge IPv4 and IPv6 versions of get_saddr() with their corresponding get_dst().
Date: Tue, 17 Oct 2006 15:42:55 -0700 [thread overview]
Message-ID: <45355C6F.90701@us.ibm.com> (raw)
In-Reply-To: <453421AD.1010906@tcs.hut.fi>
Ville Nuorvala wrote:
> As the IPv6 route lookup now also returns the selected source address
> there is no need for a separate source address lookup. In fact, the
> source address selection needs to be moved to get_dst() because the
> selected IPv6 source address isn't always stored in the route.
> Sometimes this makes it impossible to guess the correct address later on.
>
>
I remember having to do a separate call to ipv6_get_saddr()
specifically because ip6_route_output()
didn't fill in the source address. Now if the route lookup also returns
the source address, it looks logical
to remove the separate source address lookup. So i agree with the idea
behind the patch.
I will review the patch in detail and try it out next week to see that
it doesn't break SCTP
and get back to you.
I guess this is targeted for 2.6.20. Is that right?
Thanks
Sridhar
next prev parent reply other threads:[~2006-10-17 22:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-17 0:19 [PATCH 9/13] [SCTP] Merge IPv4 and IPv6 versions of get_saddr() with their corresponding get_dst() Ville Nuorvala
2006-10-17 0:31 ` [PATCH 9/13] [RFC] " Ville Nuorvala
2006-10-17 22:42 ` Sridhar Samudrala [this message]
2006-10-27 17:47 ` [PATCH 9/13] " Sridhar Samudrala
2006-11-02 12:32 ` Ville Nuorvala
2006-11-02 18:07 ` Sridhar Samudrala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45355C6F.90701@us.ibm.com \
--to=sri@us.ibm.com \
--cc=davem@davemloft.net \
--cc=kim.nordlund@nokia.com \
--cc=lksctp-developers@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
--cc=vnuorval@tcs.hut.fi \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).