From: Patrick McHardy <kaber@trash.net>
To: hadi@cyberus.ca
Cc: Russell Stuart <russell-tcatm@stuart.id.au>,
netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
Jesper Dangaard Brouer <hawk@diku.dk>
Subject: Re: [PATCH REPOST 1/2] NET: Accurate packet scheduling for ATM/ADSL (kernel)
Date: Thu, 19 Oct 2006 16:38:27 +0200 [thread overview]
Message-ID: <45378DE3.8080700@trash.net> (raw)
In-Reply-To: <1161090444.5555.13.camel@jzny2>
jamal wrote:
> ACKed-by: Jamal Hadi Salim
>
> When Patrick has his patch ready after this goes in we can revisit.
NACK.
I still think this patch shouldn't go in. There's no point in doing the
same thing twice, and I haven't heard a compelling argument why it has
to be done in a way that only helps qdiscs using rtabs while ignoring
statistics and estimators (I even provided a patch to show how to do
it without these limitations).
Besides that:
+static inline u32 qdisc_l2t(struct qdisc_rate_table* rtab, int pktlen)
+{
+ int slot = pktlen + rtab->rate.cell_align;
+ if (slot < 0)
+ slot = 0;
Why would it go negative? A negative cell_align doesn't make sense I
guess.
+ slot >>= rtab->rate.cell_log;
+ if (slot > 255)
+ return rtab->data[255] + 1;
Whats the point of this? Is it just to keep htb giant statistics
working?
next prev parent reply other threads:[~2006-10-19 14:38 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-16 23:34 [PATCH REPOST 1/2] NET: Accurate packet scheduling for ATM/ADSL (kernel) Russell Stuart
2006-10-17 13:07 ` jamal
2006-10-19 3:41 ` David Miller
2006-10-19 14:38 ` Patrick McHardy [this message]
2006-10-20 0:49 ` jamal
2006-10-20 8:54 ` Patrick McHardy
2006-10-23 11:22 ` Russell Stuart
2006-10-23 12:39 ` Patrick McHardy
2006-10-23 21:54 ` Russell Stuart
2006-10-24 16:19 ` Patrick McHardy
2006-10-24 20:00 ` Jesper Dangaard Brouer
2006-10-24 23:46 ` Russell Stuart
2006-11-30 13:07 ` Patrick McHardy
2007-01-17 23:07 ` Russell Stuart
2007-01-18 4:05 ` Patrick McHardy
2007-01-18 6:16 ` Russell Stuart
[not found] ` <45AF5C02.1010005@trash.net>
2007-01-19 3:11 ` Russell Stuart
2007-01-19 12:19 ` Patrick McHardy
2007-01-20 3:25 ` Russell Stuart
2007-01-20 8:47 ` Patrick McHardy
2007-01-21 7:45 ` Russell Stuart
2007-01-24 16:38 ` Patrick McHardy
2007-01-24 22:32 ` Russell Stuart
2007-01-25 0:06 ` Patrick McHardy
2007-01-25 0:55 ` Russell Stuart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45378DE3.8080700@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=hawk@diku.dk \
--cc=netdev@vger.kernel.org \
--cc=russell-tcatm@stuart.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).