netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 3/3] ethtool: dump_registers post mortem
Date: Sat, 21 Oct 2006 14:15:11 -0400	[thread overview]
Message-ID: <453A63AF.1010505@pobox.com> (raw)
In-Reply-To: <20061018105022.57b57b6a@freekitty>

Stephen Hemminger wrote:
> This patch allows:
> 	ethtool -d eth0 raw on >saved_regs
> and later
> 	ethtool -d eth0 file saved_regs
> 
> Selfish motive is to be able to take register dumps from users and
> and decode later, possibly adding more output as needed.
> 
> Signed-off-by: Stephen Hemminger <shemminger@osdl.org>

Would you be kind enough to roll your ethtool patches into two patches: 
  this patch, and 'more sky2 decode' patch.  I now have three sky2 
decode patches, two from 10/18 and one from 10/19.

Also, please update the man page, and possibly the -h help info, to 
indicate this enhancement.

	Jeff




  parent reply	other threads:[~2006-10-21 18:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-18 17:46 [PATCH 1/3] ethtool: sky2 GMAC decode Stephen Hemminger
2006-10-18 17:47 ` [PATCH 2/3] ethtool: sky2 more decode Stephen Hemminger
2006-10-18 17:50 ` [PATCH 3/3] ethtool: dump_registers post mortem Stephen Hemminger
2006-10-19 21:53   ` [PATCH] ethtool: more sky2 decode Stephen Hemminger
2006-10-21 18:15   ` Jeff Garzik [this message]
2006-10-23 17:51     ` [PATCH 1/3] ethtool: marvell register dump Stephen Hemminger
2006-10-23 17:57       ` [PATCH 2/3] ethtool: flie option to " Stephen Hemminger
2006-10-24  9:50         ` Ingo Oeser
2006-10-23 20:06           ` Stephen Hemminger
2007-02-09 21:29         ` Jeff Garzik
2006-10-23 17:58       ` [PATCH 3/3] ethtool: allow force hex in " Stephen Hemminger
2006-11-07  9:34       ` [PATCH 1/3] ethtool: marvell " Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=453A63AF.1010505@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).