* [PATCH] atm: fix horizon init section usage
@ 2006-10-23 2:13 Randy Dunlap
2006-10-23 3:39 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: Randy Dunlap @ 2006-10-23 2:13 UTC (permalink / raw)
To: netdev; +Cc: chas, davem
From: Randy Dunlap <randy.dunlap@oracle.com>
hrz_init() is called from the probe function, which is __devinit
and could be called after init.
WARNING: drivers/atm/horizon.o - Section mismatch: reference to .init.text:.hrz_init from .text between '.hrz_probe' (at offset 0x4054) and '.hrz_remove_one'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/atm/horizon.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletion(-)
diff -Naurp linux-2619-rc2g4/drivers/atm/horizon.c~atm_hrz_section linux-2619-rc2g4/drivers/atm/horizon.c
--- linux-2619-rc2g4/drivers/atm/horizon.c~atm_hrz_section 2006-10-20 17:37:52.822837000 -0700
+++ linux-2619-rc2g4/drivers/atm/horizon.c 2006-10-21 22:36:53.373243000 -0700
@@ -1845,7 +1845,8 @@ static u16 __init read_bia (const hrz_de
/********** initialise a card **********/
-static int __init hrz_init (hrz_dev * dev) {
+static int hrz_init (hrz_dev * dev)
+{
int onefivefive;
u16 chan;
---
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] atm: fix horizon init section usage
2006-10-23 2:13 [PATCH] atm: fix horizon init section usage Randy Dunlap
@ 2006-10-23 3:39 ` David Miller
2006-10-23 4:32 ` Randy.Dunlap
0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2006-10-23 3:39 UTC (permalink / raw)
To: randy.dunlap; +Cc: netdev, chas
From: Randy Dunlap <randy.dunlap@oracle.com>
Date: Sun, 22 Oct 2006 19:13:09 -0700
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> hrz_init() is called from the probe function, which is __devinit
> and could be called after init.
>
> WARNING: drivers/atm/horizon.o - Section mismatch: reference to .init.text:.hrz_init from .text between '.hrz_probe' (at offset 0x4054) and '.hrz_remove_one'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
It is only called from hrz_init() and thus shouldn't it be
thus marked __devinit as well? That seems to be the right
way to fix this one.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] atm: fix horizon init section usage
2006-10-23 3:39 ` David Miller
@ 2006-10-23 4:32 ` Randy.Dunlap
2006-10-23 4:39 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: Randy.Dunlap @ 2006-10-23 4:32 UTC (permalink / raw)
To: David Miller; +Cc: netdev, chas
David Miller wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> Date: Sun, 22 Oct 2006 19:13:09 -0700
>
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>
>> hrz_init() is called from the probe function, which is __devinit
>> and could be called after init.
>>
>> WARNING: drivers/atm/horizon.o - Section mismatch: reference to .init.text:.hrz_init from .text between '.hrz_probe' (at offset 0x4054) and '.hrz_remove_one'
>>
>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>
> It is only called from hrz_init() and thus shouldn't it be
> thus marked __devinit as well? That seems to be the right
> way to fix this one.
Oops, I agree. Want me to send another patch?
--
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] atm: fix horizon init section usage
2006-10-23 4:32 ` Randy.Dunlap
@ 2006-10-23 4:39 ` David Miller
2006-10-23 16:31 ` Randy.Dunlap
0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2006-10-23 4:39 UTC (permalink / raw)
To: randy.dunlap; +Cc: netdev, chas
From: "Randy.Dunlap" <randy.dunlap@oracle.com>
Date: Sun, 22 Oct 2006 21:32:20 -0700
> David Miller wrote:
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> > Date: Sun, 22 Oct 2006 19:13:09 -0700
> >
> >> From: Randy Dunlap <randy.dunlap@oracle.com>
> >>
> >> hrz_init() is called from the probe function, which is __devinit
> >> and could be called after init.
> >>
> >> WARNING: drivers/atm/horizon.o - Section mismatch: reference to .init.text:.hrz_init from .text between '.hrz_probe' (at offset 0x4054) and '.hrz_remove_one'
> >>
> >> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> >
> > It is only called from hrz_init() and thus shouldn't it be
> > thus marked __devinit as well? That seems to be the right
> > way to fix this one.
>
> Oops, I agree. Want me to send another patch?
No need, I'll take care of it, thanks Randy.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] atm: fix horizon init section usage
2006-10-23 4:39 ` David Miller
@ 2006-10-23 16:31 ` Randy.Dunlap
2006-10-24 23:17 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: Randy.Dunlap @ 2006-10-23 16:31 UTC (permalink / raw)
To: David Miller; +Cc: netdev, chas
David Miller wrote:
> From: "Randy.Dunlap" <randy.dunlap@oracle.com>
> Date: Sun, 22 Oct 2006 21:32:20 -0700
>
>> David Miller wrote:
>>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>> Date: Sun, 22 Oct 2006 19:13:09 -0700
>>>
>>>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>>>
>>>> hrz_init() is called from the probe function, which is __devinit
>>>> and could be called after init.
>>>>
>>>> WARNING: drivers/atm/horizon.o - Section mismatch: reference to .init.text:.hrz_init from .text between '.hrz_probe' (at offset 0x4054) and '.hrz_remove_one'
>>>>
>>>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>>> It is only called from hrz_init() and thus shouldn't it be
>>> thus marked __devinit as well? That seems to be the right
>>> way to fix this one.
>> Oops, I agree. Want me to send another patch?
>
> No need, I'll take care of it, thanks Randy.
David,
FYI: read_bia() also needs to be changed from __init to __devinit
since it's called from hrz_init().
--
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] atm: fix horizon init section usage
2006-10-23 16:31 ` Randy.Dunlap
@ 2006-10-24 23:17 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2006-10-24 23:17 UTC (permalink / raw)
To: randy.dunlap; +Cc: netdev, chas
From: "Randy.Dunlap" <randy.dunlap@oracle.com>
Date: Mon, 23 Oct 2006 09:31:50 -0700
> FYI: read_bia() also needs to be changed from __init to __devinit
> since it's called from hrz_init().
Thanks Randy, I've fixed this up in my tree too.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2006-10-24 23:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-23 2:13 [PATCH] atm: fix horizon init section usage Randy Dunlap
2006-10-23 3:39 ` David Miller
2006-10-23 4:32 ` Randy.Dunlap
2006-10-23 4:39 ` David Miller
2006-10-23 16:31 ` Randy.Dunlap
2006-10-24 23:17 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).