From: Patrick McHardy <kaber@trash.net>
To: "David S. Miller" <davem@davemloft.net>
Cc: Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [PKT_SCHED] netem: Orphan SKB when adding to queue.
Date: Mon, 23 Oct 2006 19:08:17 +0200 [thread overview]
Message-ID: <453CF701.2000807@trash.net> (raw)
In-Reply-To: <200610231700.k9NH0Dck016668@hera.kernel.org>
Linux Kernel Mailing List wrote:
> commit 4e8a5201506423e0241202de1349422af4260296
> tree e562a6cdbee37e3805551af92b264fa93d722c4b
> parent 6a43487f43fbd4e03c606dcb62b98374a3af88fc
> author David S. Miller <davem@sunset.davemloft.net> 1161576033 -0700
> committer David S. Miller <davem@sunset.davemloft.net> 1161576033 -0700
>
> [PKT_SCHED] netem: Orphan SKB when adding to queue.
>
> The networking emulator can queue SKBs for a very long
> time, so if you're using netem on the sender side for
> large bandwidth/delay product testing, the SKB socket
> send queue sizes become artificially larger.
>
> Correct this by calling skb_orphan() in netem_enqueue().
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
>
> drivers/pci/quirks.c | 4 ++--
> net/sched/sch_netem.c | 2 ++
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index e8a7f1b..ecf8e4d 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -1634,7 +1634,7 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_N
> * is marked here since the boot video device will be the only enabled
> * video device at this point.
> */
> -
> +#if 0
> static void __devinit fixup_video(struct pci_dev *pdev)
> {
> struct pci_dev *bridge;
> @@ -1663,7 +1663,7 @@ static void __devinit fixup_video(struct
> }
> }
> DECLARE_PCI_FIXUP_HEADER(PCI_ANY_ID, PCI_ANY_ID, fixup_video);
> -
> +#endif
This part looks like you accidentally committed it.
next parent reply other threads:[~2006-10-23 17:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200610231700.k9NH0Dck016668@hera.kernel.org>
2006-10-23 17:08 ` Patrick McHardy [this message]
2006-10-24 4:56 ` [PKT_SCHED] netem: Orphan SKB when adding to queue Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=453CF701.2000807@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).