* Re: [PKT_SCHED] netem: Orphan SKB when adding to queue. [not found] <200610231700.k9NH0Dck016668@hera.kernel.org> @ 2006-10-23 17:08 ` Patrick McHardy 2006-10-24 4:56 ` Randy Dunlap 0 siblings, 1 reply; 2+ messages in thread From: Patrick McHardy @ 2006-10-23 17:08 UTC (permalink / raw) To: David S. Miller; +Cc: Linux Netdev List Linux Kernel Mailing List wrote: > commit 4e8a5201506423e0241202de1349422af4260296 > tree e562a6cdbee37e3805551af92b264fa93d722c4b > parent 6a43487f43fbd4e03c606dcb62b98374a3af88fc > author David S. Miller <davem@sunset.davemloft.net> 1161576033 -0700 > committer David S. Miller <davem@sunset.davemloft.net> 1161576033 -0700 > > [PKT_SCHED] netem: Orphan SKB when adding to queue. > > The networking emulator can queue SKBs for a very long > time, so if you're using netem on the sender side for > large bandwidth/delay product testing, the SKB socket > send queue sizes become artificially larger. > > Correct this by calling skb_orphan() in netem_enqueue(). > > Signed-off-by: David S. Miller <davem@davemloft.net> > > drivers/pci/quirks.c | 4 ++-- > net/sched/sch_netem.c | 2 ++ > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > index e8a7f1b..ecf8e4d 100644 > --- a/drivers/pci/quirks.c > +++ b/drivers/pci/quirks.c > @@ -1634,7 +1634,7 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_N > * is marked here since the boot video device will be the only enabled > * video device at this point. > */ > - > +#if 0 > static void __devinit fixup_video(struct pci_dev *pdev) > { > struct pci_dev *bridge; > @@ -1663,7 +1663,7 @@ static void __devinit fixup_video(struct > } > } > DECLARE_PCI_FIXUP_HEADER(PCI_ANY_ID, PCI_ANY_ID, fixup_video); > - > +#endif This part looks like you accidentally committed it. ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PKT_SCHED] netem: Orphan SKB when adding to queue. 2006-10-23 17:08 ` [PKT_SCHED] netem: Orphan SKB when adding to queue Patrick McHardy @ 2006-10-24 4:56 ` Randy Dunlap 0 siblings, 0 replies; 2+ messages in thread From: Randy Dunlap @ 2006-10-24 4:56 UTC (permalink / raw) To: Patrick McHardy; +Cc: David S. Miller, Linux Netdev List On Mon, 23 Oct 2006 19:08:17 +0200 Patrick McHardy wrote: > Linux Kernel Mailing List wrote: > > commit 4e8a5201506423e0241202de1349422af4260296 > > tree e562a6cdbee37e3805551af92b264fa93d722c4b > > parent 6a43487f43fbd4e03c606dcb62b98374a3af88fc > > author David S. Miller <davem@sunset.davemloft.net> 1161576033 -0700 > > committer David S. Miller <davem@sunset.davemloft.net> 1161576033 -0700 > > > > [PKT_SCHED] netem: Orphan SKB when adding to queue. > > > > The networking emulator can queue SKBs for a very long > > time, so if you're using netem on the sender side for > > large bandwidth/delay product testing, the SKB socket > > send queue sizes become artificially larger. > > > > Correct this by calling skb_orphan() in netem_enqueue(). > > > > Signed-off-by: David S. Miller <davem@davemloft.net> > > > > drivers/pci/quirks.c | 4 ++-- > > net/sched/sch_netem.c | 2 ++ > > 2 files changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c > > index e8a7f1b..ecf8e4d 100644 > > --- a/drivers/pci/quirks.c > > +++ b/drivers/pci/quirks.c > > @@ -1634,7 +1634,7 @@ DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_N > > * is marked here since the boot video device will be the only enabled > > * video device at this point. > > */ > > - > > +#if 0 > > static void __devinit fixup_video(struct pci_dev *pdev) > > { > > struct pci_dev *bridge; > > @@ -1663,7 +1663,7 @@ static void __devinit fixup_video(struct > > } > > } > > DECLARE_PCI_FIXUP_HEADER(PCI_ANY_ID, PCI_ANY_ID, fixup_video); > > - > > +#endif > > > This part looks like you accidentally committed it. yep, already noticed & corrected on lkml. --- ~Randy ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-10-24 4:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200610231700.k9NH0Dck016668@hera.kernel.org>
2006-10-23 17:08 ` [PKT_SCHED] netem: Orphan SKB when adding to queue Patrick McHardy
2006-10-24 4:56 ` Randy Dunlap
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).