From: Ben Greear <greearb@candelatech.com>
To: David Miller <davem@davemloft.net>
Cc: Robert.Olsson@data.slu.se, netdev@vger.kernel.org
Subject: Re: RFC: Removing busy-spin in pktgen.
Date: Tue, 24 Oct 2006 09:34:38 -0700 [thread overview]
Message-ID: <453E409E.9010002@candelatech.com> (raw)
In-Reply-To: <20061024.031455.55723788.davem@davemloft.net>
David Miller wrote:
> From: Robert Olsson <Robert.Olsson@data.slu.se>
> Date: Tue, 24 Oct 2006 11:16:05 +0200
>
>
>> My first instinct is to avoid the hook in general code and pktgen let spin
>> to only affect testing.
>>
>
> Mine too.
>
> Why make everyone in the world make that check in netif_wake_queue(),
> or wherever, when %99.99999999999 of the time it'll never be used?
>
It could be a compile-time option, and even if compiled in, it should
only be an if branch on
a pointer. Is there any noticeable performance hit for an if check if
you wrap it with unlikely?
Thanks,
Ben
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2006-10-24 16:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-24 0:02 RFC: Removing busy-spin in pktgen Ben Greear
2006-10-24 9:16 ` Robert Olsson
2006-10-24 10:14 ` David Miller
2006-10-24 16:34 ` Ben Greear [this message]
2006-10-24 22:09 ` David Miller
2006-10-24 16:28 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=453E409E.9010002@candelatech.com \
--to=greearb@candelatech.com \
--cc=Robert.Olsson@data.slu.se \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).