From: Auke Kok <auke-jan.h.kok@intel.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Matthew Wilcox <matthew@wil.cx>,
john.ronciak@intel.com, jesse.brandeburg@intel.com,
jeffrey.t.kirsher@intel.com, netdev@vger.kernel.org
Subject: Re: [PATCH] Rewrite e100_phys_id
Date: Thu, 26 Oct 2006 13:04:32 -0700 [thread overview]
Message-ID: <454114D0.6050900@intel.com> (raw)
In-Reply-To: <20061026191937.GB11312@havoc.gtf.org>
Jeff Garzik wrote:
> On Thu, Oct 26, 2006 at 01:11:55PM -0600, Matthew Wilcox wrote:
>> The motivator for this was to fix the sparse warning:
>>
>> drivers/net/e100.c:2418:48: warning: cast truncates bits from constant
>> value (83126e978d4fdf becomes 978d4fdf)
>> drivers/net/e100.c:2419:37: warning: cast truncates bits from constant
>> value (83126e978d4fdf becomes 978d4fdf)
>>
>> Initially, I tried a quick fix, but when it ran into difficulties, I
>> looked at tg3.c to see how it does it. I liked their way better, so I
>> rewrote e100.c to be similar. It shaves ~700 bytes off the size of the
>> driver, and a few bytes off the size of struct nic, so I think it's a
>> win all round. Tested on the internal interface of an HP Integrity rx2600.
>>
>> Signed-off-by: Matthew Wilcox <matthew@wil.cx>
>
> Seems sane to me... I'll pick it up, if Auke doesn't...
no objections, so I'll ACK it with the notion that I'm going to let our labs do some
more testing on it with all the latest changes to it.
Jeff, I will stack it on the patches I have for 2.6.20 and push those out before the
weekend.
Cheers,
Auke
next prev parent reply other threads:[~2006-10-26 20:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-26 19:11 [PATCH] Rewrite e100_phys_id Matthew Wilcox
2006-10-26 19:19 ` Jeff Garzik
2006-10-26 20:04 ` Auke Kok [this message]
2006-10-27 2:51 ` Matthew Wilcox
2006-10-27 14:44 ` Auke Kok
2006-11-07 18:33 ` Auke Kok
2006-11-07 19:06 ` Matthew Wilcox
2006-11-07 22:34 ` Auke Kok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=454114D0.6050900@intel.com \
--to=auke-jan.h.kok@intel.com \
--cc=jeff@garzik.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=matthew@wil.cx \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).