netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Lennert Buytenhek <buytenh@wantstofly.org>
Cc: netdev@vger.kernel.org, Ray Lehtiniemi <rayl@mail.com>,
	Herbert Valerio Riedel <hvr@gnu.org>
Subject: Re: [PATCH,try2 1/3] ep93xx_eth: fix RX/TXstatus ring full handling
Date: Tue, 31 Oct 2006 20:21:03 -0500	[thread overview]
Message-ID: <4547F67F.5090806@garzik.org> (raw)
In-Reply-To: <20061030185231.GB14805@xi.wantstofly.org>

Lennert Buytenhek wrote:
> Ray Lehtiniemi reported that an incoming UDP packet flood can lock up
> the ep93xx ethernet driver.  Herbert Valerio Riedel noted that due to
> the way ep93xx_eth manages the RX/TXstatus rings, it cannot distinguish
> a full ring from an empty one, and correctly suggested that this was
> likely to be causing this lockup to occur.
> 
> Instead of looking at the hardware's RX/TXstatus ring write pointers
> to determine when to stop reading from those rings, we should just check
> every individual RX/TXstatus descriptor's valid bit instead, since there
> is no other way to distinguish an empty ring from a full ring, and if
> there is a descriptor waiting, we take the hit of reading the descriptor
> from memory anyway.
> 
> Signed-off-by: Lennert Buytenhek <buytenh@wantstofly.org>

applied 1-3



      reply	other threads:[~2006-11-01  1:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-30 18:52 [PATCH,try2 1/3] ep93xx_eth: fix RX/TXstatus ring full handling Lennert Buytenhek
2006-11-01  1:21 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4547F67F.5090806@garzik.org \
    --to=jeff@garzik.org \
    --cc=buytenh@wantstofly.org \
    --cc=hvr@gnu.org \
    --cc=netdev@vger.kernel.org \
    --cc=rayl@mail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).