From: Eric Dumazet <dada1@cosmosbay.com>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC, PATCH] dont insert sockets/pipes dentries into dentry_hashtable.
Date: Wed, 01 Nov 2006 10:04:20 +0100 [thread overview]
Message-ID: <45486314.3020300@cosmosbay.com> (raw)
In-Reply-To: <20061101083811.GS29920@ftp.linux.org.uk>
Al Viro a écrit :
> On Wed, Nov 01, 2006 at 09:21:06AM +0100, Eric Dumazet wrote:
>
>> And " (deleted)" is correctly added to deleted files.
>
> The hell it will.
>
> touch a
> touch b
> exec 5<a
> mv b a
> ls -l /proc/$$/fd/5
>
> With your patch and without it, please.
Yes I will do, thanks.
>
> PS: getting rid of socket dentries is a bad idea with the capital "Fuck, No".
> For those who want to see where does that path lead and are attracted to
> trainwrecks in general I can recommend *BSD socket handling. They have
> paid quite painfully for lack of proper vnodes. It's simply not worth
> the resulting trouble.
I have one server with one million sockets, wasting 210 MB of ram for dentries
that are only used when some guy does some /proc/$pid/fd work
Socket hot path already dont use anymore dentries, thanks to file->private_data
Eric
next prev parent reply other threads:[~2006-11-01 9:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-24 14:17 [PATCH] fix integer overflow in H-TCP congestion control Gavin McCullagh
2006-10-24 22:30 ` David Miller
2006-10-25 8:47 ` Gavin McCullagh
2006-10-26 6:06 ` David Miller
2006-10-31 18:48 ` [RFC, PATCH] dont insert sockets/pipes dentries into dentry_hashtable Eric Dumazet
2006-11-01 7:19 ` David Miller
2006-11-01 8:21 ` Eric Dumazet
2006-11-01 8:34 ` David Miller
2006-11-01 8:38 ` Al Viro
2006-11-01 8:42 ` Al Viro
2006-11-01 9:04 ` Eric Dumazet [this message]
2006-11-01 13:54 ` Eric Dumazet
2006-11-22 18:00 ` [PATCH] [NET] dont insert socket " Eric Dumazet
2006-11-28 23:35 ` David Miller
2006-11-29 0:13 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45486314.3020300@cosmosbay.com \
--to=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).