netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Larry Finger <Larry.Finger@lwfinger.net>
To: Michael Buesch <mb@bu3sch.de>
Cc: linville@tuxdriver.com, netdev@vger.kernel.org,
	bcm43xx-dev@lists.berlios.de,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH] bcm43xx: Drain TX status before starting IRQs
Date: Wed, 01 Nov 2006 23:46:27 -0600	[thread overview]
Message-ID: <45498633.7040808@lwfinger.net> (raw)
In-Reply-To: <200610191729.35402.mb@bu3sch.de>

Michael Buesch wrote:
> Drain the Microcode TX-status-FIFO before we enable IRQs.
> This is required, because the FIFO may still have entries left
> from a previous run. Those would immediately fire after enabling
> IRQs and would lead to an oops in the DMA TXstatus handling code.
> 
> Signed-off-by: Michael Buesch <mb@bu3sch.de>
> 
> --
> 
> Please consider also pushing this into the -stable tree.
> The bug is not likely to trigger, but at least ben
> triggered it in the past. Anyway, it can't hurt much to
> drain the FIFO before running the device.
> 
> Note that this is diffed against 2.6.18.1 and not 2.6.18
> as the diff prolog suggests. I just forgot to rename
> the directory. ;)

Has anyone used this patch, particularly with WPA encryption? When I try it, wpa_supplicant 
immediately uses 90+% of the cpu and never actually authenticates with my AP. I wonder if it is 
something with my system.

Thanks,

Larry


  parent reply	other threads:[~2006-11-02  5:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-19 15:29 [PATCH] bcm43xx: Drain TX status before starting IRQs Michael Buesch
     [not found] ` <200610191729.35402.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
2006-10-20  0:25   ` Benjamin Herrenschmidt
2006-11-02  5:46 ` Larry Finger [this message]
     [not found]   ` <45498633.7040808-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2006-11-02  8:45     ` Johannes Berg
2006-11-03 16:56       ` Jouni Malinen
     [not found]         ` <20061103165627.GC16894-T6t7IcXamKWaos4igUoMUw@public.gmane.org>
2006-11-04 16:38           ` Larry Finger
  -- strict thread matches above, loose matches on Subject: below --
2006-11-05 21:34 Larry Finger
2006-11-06 15:45 Larry Finger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45498633.7040808@lwfinger.net \
    --to=larry.finger@lwfinger.net \
    --cc=bcm43xx-dev@lists.berlios.de \
    --cc=benh@kernel.crashing.org \
    --cc=linville@tuxdriver.com \
    --cc=mb@bu3sch.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).