From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH] s2io ppc64 fix for readq/writeq Date: Mon, 06 Nov 2006 04:55:04 -0500 Message-ID: <454F0678.50706@pobox.com> References: <1162780109.28571.273.camel@localhost.localdomain> <454EE943.6000603@pobox.com> <1162806168.28571.309.camel@localhost.localdomain> <1162806691.28571.311.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Linus Torvalds , netdev@vger.kernel.org Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:20615 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S1423688AbWKFJzH (ORCPT ); Mon, 6 Nov 2006 04:55:07 -0500 To: Benjamin Herrenschmidt In-Reply-To: <1162806691.28571.311.camel@localhost.localdomain> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Benjamin Herrenschmidt wrote: > On Mon, 2006-11-06 at 01:50 -0800, Linus Torvalds wrote: >> On Mon, 6 Nov 2006, Benjamin Herrenschmidt wrote: >>> Anyway, what do you think of Jeff proposal to just implement them as two >>> 32 bits operations ? My arch guy side screams at the idea, but if, >>> indeed, drivers generally cope fine with it, I suppose that's ok. >> Last I saw, that's how normal PCI will split the IO anyway, so I guess it >> makes sense. > > Hrm.. true indeed. I'll implement them that way for ppc32 then. Bonus points if you want to find-and-kill where individual drivers did #ifndef readq implement readq and writeq by hand... #endif :)