* [patch 2/9] com20020 build fix
@ 2006-11-09 3:51 akpm
2006-11-10 16:09 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2006-11-09 3:51 UTC (permalink / raw)
To: davem; +Cc: netdev, akpm, randy.dunlap, toralf.foerster
From: Randy Dunlap <randy.dunlap@oracle.com>
com20020.c needs to export functions if either of the ISA or PCI modules
are built as loadable modules. Or they could always be exported.
WARNING: "com20020_found" [drivers/net/arcnet/com20020-pci.ko] undefined!
WARNING: "com20020_check" [drivers/net/arcnet/com20020-pci.ko] undefined!
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Toralf Forster <toralf.foerster@gmx.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---
drivers/net/arcnet/com20020.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff -puN drivers/net/arcnet/com20020.c~com20020-build-fix drivers/net/arcnet/com20020.c
--- a/drivers/net/arcnet/com20020.c~com20020-build-fix
+++ a/drivers/net/arcnet/com20020.c
@@ -337,13 +337,16 @@ static void com20020_set_mc_list(struct
}
}
-#ifdef MODULE
-
+#if defined(CONFIG_ARCNET_COM20020_PCI_MODULE) || \
+ defined(CONFIG_ARCNET_COM20020_ISA_MODULE)
EXPORT_SYMBOL(com20020_check);
EXPORT_SYMBOL(com20020_found);
+#endif
MODULE_LICENSE("GPL");
+#ifdef MODULE
+
int init_module(void)
{
BUGLVL(D_NORMAL) printk(VERSION);
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 2/9] com20020 build fix
2006-11-09 3:51 [patch 2/9] com20020 build fix akpm
@ 2006-11-10 16:09 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2006-11-10 16:09 UTC (permalink / raw)
To: akpm; +Cc: davem, netdev, randy.dunlap, toralf.foerster
akpm@osdl.org wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> com20020.c needs to export functions if either of the ISA or PCI modules
> are built as loadable modules. Or they could always be exported.
>
> WARNING: "com20020_found" [drivers/net/arcnet/com20020-pci.ko] undefined!
> WARNING: "com20020_check" [drivers/net/arcnet/com20020-pci.ko] undefined!
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Toralf Forster <toralf.foerster@gmx.de>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
applied; please CC me on this drivers/net stuff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-11-10 16:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-09 3:51 [patch 2/9] com20020 build fix akpm
2006-11-10 16:09 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).