netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: netdev <netdev@vger.kernel.org>
Subject: airo driver: still can't deal with interface renames?
Date: Sun, 12 Nov 2006 19:15:36 +0300	[thread overview]
Message-ID: <455748A8.2000205@tls.msk.ru> (raw)

A long time ago, in kernel-2.4 days, I noticed that
airo module (for various aironet etc cards) can't
handle interface renames (at that time, the kernel
crashed after `ip link set eth1 name xxx' command
and some packets going to/from the interface).

The problem seems to be that the driver uses some
sort of private data in /proc/driver/airo/ethN/ which
gets created when the driver discovers an interface
and names it as usual, giving next available N in
ethN scheme.

And currently (2.6.18) the situation is still similar.
Well, it does not crashes, but still keeps the directory
in /proc/driver/airo named after the automatic interface
name, which leads to confusion at least, especially if
i load airo.ko, rename the iface, and next load some other
network driver module, which grabs THE SAME ethN as was
first grabbed by airo.

The fix seems to be to follow interface renames with name
change in /proc/driver/airo/.  Or, better longterm but
leads to incompatibilities, switch to using sysfs interface,
where the change will be made automagically.

I don't understand all the driver internals to a level when
I can fix the problem in the right way.  But I can fix it
with a hack, which seems to be simple enouth and will suit
at least my needs: by introducing another array of charp
for module parameters, giving the name(s) of interface(s)
it should create, just like currently it accepts "ssids"
and "rates" parameters.

Can someone comment on the situation, please?

Thanks.

/mjt

                 reply	other threads:[~2006-11-12 16:15 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=455748A8.2000205@tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).