[Fwd: Re: wan/pc300 bug found]

[Fwd: Re: wan/pc300 bug found]

[Jeff Garzik]

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]

FYI...  I'm certainly willing to remove pc300, if nobody wants it.

But I am unsure whether this is a case of "vendor doesn't care" or 
"users don't care", which are two very different things...

	Jeff



[-- Attachment #2: Re: wan/pc300 bug found --]
[-- Type: message/rfc822, Size: 2050 bytes --]

From: "Squassoni, Daniela" <Daniela.Squassoni@avocent.com>
To: "Jeff Garzik" <jeff@garzik.org>
Cc: "Rosalino, Wanda" <Wanda.Rosalino@avocent.com>
Subject: RE: wan/pc300 bug found
Date: Tue, 14 Nov 2006 05:43:29 -0600
Message-ID: <1EF69AC43C5ABC49985E42B84575ADB7091CEA8E@hsv-email.corp.avocent.com>


Jeff,

As PC300 is not being produced anymore, we decided that the best solution is to remove its driver from the kernel. I will send you a patch to do so, as soon as possible.

Best regards,

Daniela


-----Original Message-----
From: Jeff Garzik [mailto:jeff@garzik.org]
Sent: Sun 10/1/2006 1:35 PM
To: pc300@cyclades.com; khc@pm.waw.pl; netdev@vger.kernel.org; LKML; Andrew Morton
Subject: wan/pc300 bug found
 

The following gcc warning indicates a bug:

drivers/net/wan/pc300_drv.c: In function 'cpc_open':
drivers/net/wan/pc300_drv.c:2870: warning: 'br' may be used uninitialized in this function

clock_rate_calc() is not checked for a negative return value.

Re: [Fwd: Re: wan/pc300 bug found]

[Arnaldo Carvalho de Melo]

On 11/14/06, Jeff Garzik <jeff@garzik.org> wrote:
> FYI...  I'm certainly willing to remove pc300, if nobody wants it.
>
> But I am unsure whether this is a case of "vendor doesn't care" or
> "users don't care", which are two very different things...

Well, I'm not a user of such card, but I know there are many users at
least here in Brazil, I guess it should stay.

- Arnaldo

Re: [Fwd: Re: wan/pc300 bug found]

[Krzysztof Halasa]

Jeff Garzik <jeff@garzik.org> writes:

> FYI...  I'm certainly willing to remove pc300, if nobody wants it.
>
> But I am unsure whether this is a case of "vendor doesn't care" or
> "users don't care", which are two very different things...

I have a driver for PC300/RSV (dual V.35 + V.24) for years. I'm told
it works with X.21 version too. If someone has a spare T1/E1 card
(non-returnable donation only) I can try to add support as well.

T1/E1 is too complicated to maintain without the actual hardware.

Perhaps we should add my driver to the tree, mark the old one as
obsolete and look for angry reports from T1/E1 users?

My driver(s) doesn't support MLPPP but that's probably easy to change
if there is any interest.
-- 
Krzysztof Halasa

Re: [Fwd: Re: wan/pc300 bug found]

[Jeff Garzik]

Krzysztof Halasa wrote:
> Jeff Garzik <jeff@garzik.org> writes:
> 
>> FYI...  I'm certainly willing to remove pc300, if nobody wants it.
>>
>> But I am unsure whether this is a case of "vendor doesn't care" or
>> "users don't care", which are two very different things...
> 
> I have a driver for PC300/RSV (dual V.35 + V.24) for years. I'm told
> it works with X.21 version too. If someone has a spare T1/E1 card
> (non-returnable donation only) I can try to add support as well.
> 
> T1/E1 is too complicated to maintain without the actual hardware.
> 
> Perhaps we should add my driver to the tree, mark the old one as
> obsolete and look for angry reports from T1/E1 users?

No objections...

	Jeff

Re: [Fwd: Re: wan/pc300 bug found]

[Krzysztof Halasa]

Hi,

Jeff Garzik <jeff@garzik.org> writes:

>> I have a driver for PC300/RSV (dual V.35 + V.24) for years. I'm told
>> it works with X.21 version too. If someone has a spare T1/E1 card
>> (non-returnable donation only) I can try to add support as well.
>> T1/E1 is too complicated to maintain without the actual hardware.
>> Perhaps we should add my driver to the tree, mark the old one as
>> obsolete and look for angry reports from T1/E1 users?
>
> No objections...

Great. I'm not marking the original pc300 driver as obsolete
- should I? It supports (at least theoretically) multi line PPP
and PC300 T1/E1, my drivers don't.
-- 
Krzysztof Halasa