From: Jeff Garzik <jgarzik@pobox.com>
To: Haavard Skinnemoen <hskinnemoen@atmel.com>
Cc: netdev@vger.kernel.org, Andrew Victor <andrew@sanpeople.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH take 2] Atmel MACB ethernet driver
Date: Tue, 14 Nov 2006 10:43:46 -0500 [thread overview]
Message-ID: <4559E432.9070401@pobox.com> (raw)
In-Reply-To: <20061109145117.577e3c61@cad-250-152.norway.atmel.com>
Haavard Skinnemoen wrote:
> Driver for the Atmel MACB on-chip ethernet module.
>
> Tested on AVR32/AT32AP7000/ATSTK1000. I've heard rumours that it works
> with AT91SAM9260 as well, and it may be possible to share some code with
> the at91_ether driver for AT91RM9200.
>
> Hardware documentation can be found in the AT32AP7000 data sheet,
> which can be downloaded from
>
> http://www.atmel.com/dyn/products/datasheets.asp?family_id=682
>
> Changes since previous version:
> * Probe for PHY ID instead of depending on it being provided through
> platform_data.
> * Grab initial ethernet address from the MACB registers instead
> of depending on platform_data.
> * Set MII/RMII mode correctly.
>
> These changes are mostly about making the driver more compatible with
> the at91 infrastructure.
>
> Signed-off-by: Haavard Skinnemoen <hskinnemoen@atmel.com>
applied.
Thanks for submitting a nice, clean driver that was so painless to apply
to the latest kernel.
I wish all vendors were as effective and efficient.
Jeff
prev parent reply other threads:[~2006-11-14 15:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-09 13:51 [PATCH take 2] Atmel MACB ethernet driver Haavard Skinnemoen
2006-11-14 15:43 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4559E432.9070401@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=andrew@sanpeople.com \
--cc=hskinnemoen@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).