* [PATCH 3/10][NETLABEL]: Use kmemdup in cipso_ipv4.c
@ 2006-11-17 15:17 Arnaldo Carvalho de Melo
2006-11-17 17:48 ` Paul Moore
0 siblings, 1 reply; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2006-11-17 15:17 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev
Code diff stats:
[acme@newtoy net-2.6.20]$ codiff /tmp/cipso_ipv4.o.before /tmp/cipso_ipv4.o.after
/pub/scm/linux/kernel/git/acme/net-2.6.20/net/ipv4/cipso_ipv4.c:
cipso_v4_cache_add | -46
1 function changed, 46 bytes removed
[acme@newtoy net-2.6.20]$
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
---
net/ipv4/cipso_ipv4.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/cipso_ipv4.c b/net/ipv4/cipso_ipv4.c
index c3a61eb..095038a 100644
--- a/net/ipv4/cipso_ipv4.c
+++ b/net/ipv4/cipso_ipv4.c
@@ -377,12 +377,11 @@ int cipso_v4_cache_add(const struct sk_b
entry = kzalloc(sizeof(*entry), GFP_ATOMIC);
if (entry == NULL)
return -ENOMEM;
- entry->key = kmalloc(cipso_ptr_len, GFP_ATOMIC);
+ entry->key = kmemdup(cipso_ptr, cipso_ptr_len, GFP_ATOMIC);
if (entry->key == NULL) {
ret_val = -ENOMEM;
goto cache_add_failure;
}
- memcpy(entry->key, cipso_ptr, cipso_ptr_len);
entry->key_len = cipso_ptr_len;
entry->hash = cipso_v4_map_cache_hash(cipso_ptr, cipso_ptr_len);
atomic_inc(&secattr->cache->refcount);
--
1.4.2.1.g3d5c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 3/10][NETLABEL]: Use kmemdup in cipso_ipv4.c
2006-11-17 15:17 [PATCH 3/10][NETLABEL]: Use kmemdup in cipso_ipv4.c Arnaldo Carvalho de Melo
@ 2006-11-17 17:48 ` Paul Moore
0 siblings, 0 replies; 2+ messages in thread
From: Paul Moore @ 2006-11-17 17:48 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo; +Cc: David S. Miller, netdev
Arnaldo Carvalho de Melo wrote:
> Code diff stats:
>
> [acme@newtoy net-2.6.20]$ codiff /tmp/cipso_ipv4.o.before /tmp/cipso_ipv4.o.after
> /pub/scm/linux/kernel/git/acme/net-2.6.20/net/ipv4/cipso_ipv4.c:
> cipso_v4_cache_add | -46
> 1 function changed, 46 bytes removed
> [acme@newtoy net-2.6.20]$
>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
Acked-by: Paul Moore <paul.moore@hp.com>
Looks fine to me.
--
paul moore
linux security @ hp
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-11-17 17:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-17 15:17 [PATCH 3/10][NETLABEL]: Use kmemdup in cipso_ipv4.c Arnaldo Carvalho de Melo
2006-11-17 17:48 ` Paul Moore
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).