From: Bryan O'Sullivan <bos@pathscale.com>
To: Steve Wise <swise@opengridcomputing.com>
Cc: rdreier@cisco.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, openib-general@openib.org
Subject: Re: [openib-general] [PATCH 09/13] Core WQE/CQE Types
Date: Fri, 17 Nov 2006 10:19:15 -0800 [thread overview]
Message-ID: <455DFD23.8050504@pathscale.com> (raw)
In-Reply-To: <20061116035912.22635.21736.stgit@dell3.ogc.int>
Steve Wise wrote:
> T3 WQE and CQE structures, defines, etc...
I notice that none of the fields in these structs seem to be
endianness-annotated, but that there's a lot of cpu_to_be64 and so on
being used to frob values into them. Please make sure that the driver
passes a sparse check, which it looks like it almost certainly cannot
right now.
> +#define RING_DOORBELL(doorbell, QPID) { \
> + (writel(((1<<31) | (QPID)), doorbell)); \
> +}
Should probably be an inline function instead of a macro.
<b
next prev parent reply other threads:[~2006-11-17 18:18 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-16 3:58 [PATCH 00/13] Chelsio T3 RDMA Driver Steve Wise
2006-11-16 3:58 ` [PATCH 01/13] Linux RDMA Core Changes Steve Wise
2006-11-16 19:41 ` Roland Dreier
2006-11-16 3:58 ` [PATCH 02/13] Device Discovery and ULLD Linkage Steve Wise
2006-11-17 17:53 ` [openib-general] " Bryan O'Sullivan
2006-11-17 17:59 ` Steve Wise
2006-11-16 3:58 ` [PATCH 03/13] Provider Methods and Data Structures Steve Wise
2006-11-16 3:58 ` [PATCH 04/13] Connection Manager Steve Wise
2006-11-17 18:07 ` [openib-general] " Bryan O'Sullivan
2006-11-17 18:26 ` Steve Wise
2006-11-16 3:58 ` [PATCH 05/13] Queue Pairs Steve Wise
2006-11-16 3:58 ` [PATCH 06/13] Completion Queues Steve Wise
2006-11-16 3:59 ` [PATCH 07/13] Async Event Handler Steve Wise
2006-11-16 3:59 ` [PATCH 08/13] Memory Registration Steve Wise
2006-11-16 3:59 ` [PATCH 09/13] Core WQE/CQE Types Steve Wise
2006-11-17 4:45 ` Roland Dreier
2006-11-17 17:02 ` Steve Wise
2006-11-17 18:19 ` Bryan O'Sullivan [this message]
2006-11-17 18:32 ` [openib-general] " Steve Wise
2006-11-17 18:45 ` Bryan O'Sullivan
2006-11-16 3:59 ` [PATCH 10/13] Core HAL Steve Wise
2006-11-16 3:59 ` [PATCH 11/13] Core Resource Allocation Steve Wise
2006-11-17 16:54 ` Roland Dreier
2006-11-17 17:25 ` Steve Wise
2006-11-17 20:37 ` Roland Dreier
2006-11-16 3:59 ` [PATCH 12/13] Core Debug functions Steve Wise
2006-11-16 3:59 ` [PATCH 13/13] Kconfig/Makefile Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=455DFD23.8050504@pathscale.com \
--to=bos@pathscale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=openib-general@openib.org \
--cc=rdreier@cisco.com \
--cc=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).