From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-15?Q?Mika_Penttil=E4?= Subject: Re: [NET_SCHED 03/06]: Fix endless loops caused by inaccurate qlen counters (part 1) Date: Mon, 20 Nov 2006 16:44:20 +0200 Message-ID: <4561BF44.4040801@kolumbus.fi> References: <20061120130834.22347.34853.sendpatchset@localhost.localdomain> <20061120130840.22347.54563.sendpatchset@localhost.localdomain> <4561BA7B.4060005@kolumbus.fi> <4561BC31.5030405@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: davem@davemloft.net, devik@cdi.cz, netdev@vger.kernel.org Return-path: Received: from mail-gw1.turkuamk.fi ([195.148.208.125]:46289 "EHLO mail-gw1.turkuamk.fi") by vger.kernel.org with ESMTP id S934208AbWKTOqQ convert rfc822-to-8bit (ORCPT ); Mon, 20 Nov 2006 09:46:16 -0500 To: Patrick McHardy In-Reply-To: <4561BC31.5030405@trash.net> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Patrick McHardy wrote: > Mika Penttil=E4 wrote: > =20 >> Are you sure you didn't mean to : >> >> + while ((parentid =3D sch->parent)) { >> + sch =3D __qdisc_lookup(sch->dev, TC_H_MAJ(parentid)); >> + cops =3D sch->ops->cl_ops; >> + if (!(sch->q.qlen -=3D n) && cops->qlen_notify) { <---- >> =20 > > > We could do that, currently the qdiscs check themselves. > The idea was mainly that they could be interested in > other changes as well, for example for recalculating > a deadline when the next packet in line changes. > > =20 But you call the notify before the decrement, which seems odd... --Mika