From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Drake Subject: Re: [PATCH] softmac: remove netif_tx_disable when scanning Date: Sat, 25 Nov 2006 23:05:07 -0500 Message-ID: <45691273.9090803@gentoo.org> References: <4568DCEB.mailLLK1Z24PM@lwfinger.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: John Linville , Michael Buesch , netdev@vger.kernel.org, Bcm43xx-dev@lists.berlios.de, Stefano Brivio Return-path: Received: from smtp151.iad.emailsrvr.com ([207.97.245.151]:2480 "EHLO smtp151.iad.emailsrvr.com") by vger.kernel.org with ESMTP id S967294AbWKZEKq (ORCPT ); Sat, 25 Nov 2006 23:10:46 -0500 To: Larry Finger In-Reply-To: <4568DCEB.mailLLK1Z24PM@lwfinger.net> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Larry Finger wrote: > In the scan section of ieee80211softmac, network transmits are disabled. > Clearly, this does not make any sense as transmit is necessary for active > scanning, and transmits are not used when passive scanning. Probe request frames are generated by softmac and do not go through the TX queue. Disabling the TX queue has no effect on that. Surely disabling the queue actually makes sense, in order to avoid frames designated for the "current session" being transmitted on different channels during scanning? Daniel