From: Patrick McHardy <kaber@trash.net>
To: Adrian Bunk <bunk@stusta.de>
Cc: Thomas Graf <tgraf@suug.ch>,
netdev@vger.kernel.org, jamal <hadi@cyberus.ca>
Subject: Re: RFC: remove NET_CLS_POLICE?
Date: Sun, 26 Nov 2006 14:21:49 +0100 [thread overview]
Message-ID: <456994ED.9040405@trash.net> (raw)
In-Reply-To: <20061126062939.GM15364@stusta.de>
Adrian Bunk wrote:
> Considering that NET_CLS_POLICE has been marked as obsolete for more
> than one year, would a patch to remove it be acceptable?
Looking at this, the only reason I thought why we kept this
option was to keep old iproute binaries working. But struct
tc_police in new kernels is bigger than in old ones (new
refcnt, bindcnt and capab members) and both the old and the
action version of the policer check for an exact size match.
Which means old binaries don't work with either NET_CLS_POLICE
or NET_ACT_POLICE. I'll look into fixing this.
One more thing NET_CLS_POLICE affects is CBQ reshape/reclassify
handling, reshape_fail seems to be completely unhandled without
NET_CLS_POLICE and reclassification looks like it behaves
differently with tc actions. I'm not really sure what the
reshape_fail stuff is used for, but it looks like we would loose
a feature. Jamal?
next prev parent reply other threads:[~2006-11-26 13:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-26 6:29 RFC: remove NET_CLS_POLICE? Adrian Bunk
2006-11-26 13:21 ` Patrick McHardy [this message]
2006-11-27 8:56 ` Thomas Graf
2006-12-01 3:52 ` David Miller
2006-11-26 23:09 ` Andy Furniss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=456994ED.9040405@trash.net \
--to=kaber@trash.net \
--cc=bunk@stusta.de \
--cc=hadi@cyberus.ca \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).