From: Larry Finger <Larry.Finger-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
To: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Stefano Brivio <st3-sGOZH3hwPm2sTnJN9+BGXg@public.gmane.org>,
John Linville <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>,
Michael Buesch <mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>,
Daniel Drake <dsd-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>,
Bcm43xx-dev-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org
Subject: Re: [PATCH] softmac: remove netif_tx_disable when scanning
Date: Sun, 26 Nov 2006 13:03:09 -0600 [thread overview]
Message-ID: <4569E4ED.3020507@lwfinger.net> (raw)
In-Reply-To: <1164566436.22909.26.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>
Johannes Berg wrote:
> On Sun, 2006-11-26 at 13:25 -0500, Daniel Drake wrote:
>
>> No, we could stick with our existing setup if the stack did something
>> different.
>
> But you do need full refcounting I guess.
>
>>> Because for
>>> the stack it wouldn't be required if it'd simply not start scanning when
>>> queue is disabled and stop scanning immediately when queue stop is
>>> requested.
>> That would work, assuming there is a way to make the stack listen for
>> the "TX queue stopped" event (or would the ieee80211_tx_disable wrapper
>> take care of that?).
>
> A wrapper is what I had in mind, I don't think there's any notification
> for these things.
If someone will prepare a patch that will fix this, I can test it. Otherwise, I'm prepared to
substitute the bug that doesn't hurt anything for the one that I have shown does cause problems.
Larry
next prev parent reply other threads:[~2006-11-26 19:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-26 0:16 [PATCH] softmac: remove netif_tx_disable when scanning Larry Finger
2006-11-26 4:05 ` Daniel Drake
2006-11-26 10:03 ` Johannes Berg
2006-11-26 12:12 ` Michael Buesch
[not found] ` <200611261312.20442.mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org>
2006-11-26 13:05 ` Larry Finger
[not found] ` <4569912C.1000506-tQ5ms3gMjBLk1uMJSBkQmQ@public.gmane.org>
2006-11-26 13:06 ` Michael Buesch
[not found] ` <1164535408.21459.3.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>
2006-11-26 16:37 ` Daniel Drake
2006-11-26 16:51 ` Johannes Berg
[not found] ` <1164559882.22909.5.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>
2006-11-26 18:25 ` Daniel Drake
2006-11-26 18:40 ` Johannes Berg
[not found] ` <1164566436.22909.26.camel-YfaajirXv214zXjbi5bjpg@public.gmane.org>
2006-11-26 19:03 ` Larry Finger [this message]
2006-11-27 4:13 ` Daniel Drake
2006-11-27 15:49 ` Michael Buesch
[not found] ` <45691273.9090803-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2006-11-26 10:07 ` Johannes Berg
2006-11-26 12:25 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4569E4ED.3020507@lwfinger.net \
--to=larry.finger-tq5ms3gmjblk1umjsbkqmq@public.gmane.org \
--cc=Bcm43xx-dev-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org \
--cc=dsd-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org \
--cc=johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org \
--cc=linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \
--cc=mb-fseUSCV1ubazQB+pC5nmwQ@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=st3-sGOZH3hwPm2sTnJN9+BGXg@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).