From: Patrick McHardy <kaber@trash.net>
To: Jarek Poplawski <jarkao2@o2.pl>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH][NET_SCHED] sch_cbq: deactivating when grafting, purging etc.
Date: Mon, 27 Nov 2006 10:55:39 +0100 [thread overview]
Message-ID: <456AB61B.3040205@trash.net> (raw)
In-Reply-To: <20061127065614.GB1625@ff.dom.local>
Jarek Poplawski wrote:
> Here are some fixes proposals suggested by Patrick McHardy.
>
> [NET_SCHED] sch_cbq:
>
> - deactivating of active classes when grafting
>
> - purging of queue/q.qlen adjustment when deleting an active class
>
> - deactivating of active classes when q.qlen drops to zero in ->drop()
>
> - a redundant instruction removed from cbq_deactivate_class (my own
> suggestion)
>
> PS: - purging of queue and deactivating of active classes
> when attaching a new child - not done (according to man, CBQ can carry
> packets in any type of nodes).
Your patch looks good, but it conflicts with my patches.
One thing I forgot to mention is that it should also have
a callback for deactivating classes when their childs
become empty. If you do that you can just call
disc_tree_decrement_qlen in graft/delete, which will take
care of the qlen decrement and class deactivation.
next prev parent reply other threads:[~2006-11-27 9:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-27 6:56 [PATCH][NET_SCHED] sch_cbq: deactivating when grafting, purging etc Jarek Poplawski
2006-11-27 9:55 ` Patrick McHardy [this message]
2006-11-27 10:41 ` Jarek Poplawski
2006-11-27 10:39 ` Patrick McHardy
2006-11-28 6:37 ` Jarek Poplawski
2006-11-30 12:22 ` Patrick McHardy
2006-12-08 8:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=456AB61B.3040205@trash.net \
--to=kaber@trash.net \
--cc=jarkao2@o2.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).