From: Auke Kok <auke-jan.h.kok@intel.com>
To: Willy Tarreau <w@1wt.eu>
Cc: jeff@garzik.org, davem@davemloft.net, linux-net@vger.kernel.org,
NetDev <netdev@vger.kernel.org>
Subject: Re: [PATCH-2.4] e100: incorrect use of "&&" instead of "&"
Date: Mon, 27 Nov 2006 09:31:34 -0800 [thread overview]
Message-ID: <456B20F6.8010009@intel.com> (raw)
In-Reply-To: <20061125213517.GA5965@1wt.eu>
Willy Tarreau wrote:
> Hi guys,
>
> I'm about to apply this fix to 2.4. 2.6 is not affected.
> Do you have any objection ?
Willy,
you didn't CC netdev. linux-net is a users list, you didn't CC the maintainers of the
driver. Please do this. We're more than happy to help, even for 2.4 kernels.
Patch looks good, please apply.
Acked-by: Auke Kok <auke-jan.h.kok@intel.com>
Cheers,
Auke
>
> Thanks in advance,
> Willy
>
>
> From e716301a8829bd45e60ac48939afa80753534b59 Mon Sep 17 00:00:00 2001
> From: Willy Tarreau <w@1wt.eu>
> Date: Sat, 25 Nov 2006 22:11:36 +0100
> Subject: [PATCH] e100: incorrect use of "&&" instead of "&"
>
> In e100_do_ethtool_ioctl(), bdp->flags is a bitfield and is
> checked for some bits but the AND operation is performed with
> && instead of &. Obvious fix is to use "&" as in all other
> places. 2.6 does not seem affected.
>
> Signed-off-by: Willy Tarreau <w@1wt.eu>
> ---
> drivers/net/e100/e100_main.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/e100/e100_main.c b/drivers/net/e100/e100_main.c
> index c9d801a..d67a145 100644
> --- a/drivers/net/e100/e100_main.c
> +++ b/drivers/net/e100/e100_main.c
> @@ -3292,11 +3292,11 @@ #ifdef ETHTOOL_GPAUSEPARAM
> if ((bdp->flags & IS_BACHELOR)
> && (bdp->params.b_params & PRM_FC)) {
> epause.autoneg = 1;
> - if (bdp->flags && DF_LINK_FC_CAP) {
> + if (bdp->flags & DF_LINK_FC_CAP) {
> epause.rx_pause = 1;
> epause.tx_pause = 1;
> }
> - if (bdp->flags && DF_LINK_FC_TX_ONLY)
> + if (bdp->flags & DF_LINK_FC_TX_ONLY)
> epause.tx_pause = 1;
> }
> rc = copy_to_user(ifr->ifr_data, &epause, sizeof(epause))
next parent reply other threads:[~2006-11-27 17:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20061125213517.GA5965@1wt.eu>
2006-11-27 17:31 ` Auke Kok [this message]
2006-11-28 1:05 ` [PATCH-2.4] e100: incorrect use of "&&" instead of "&" Willy Tarreau
2006-11-28 8:03 ` Auke Kok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=456B20F6.8010009@intel.com \
--to=auke-jan.h.kok@intel.com \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=linux-net@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).