Re: [PATCH-2.4] e100: incorrect use of "&&" instead of "&"

Re: [PATCH-2.4] e100: incorrect use of "&&" instead of "&"

[Auke Kok]

Willy Tarreau wrote:
> Hi guys,
> 
> I'm about to apply this fix to 2.4. 2.6 is not affected.
> Do you have any objection ?

Willy,

you didn't CC netdev. linux-net is a users list, you didn't CC the maintainers of the 
driver. Please do this. We're more than happy to help, even for 2.4 kernels.


Patch looks good, please apply.

Acked-by: Auke Kok <auke-jan.h.kok@intel.com>

Cheers,

Auke


> 
> Thanks in advance,
> Willy
> 
> 
> From e716301a8829bd45e60ac48939afa80753534b59 Mon Sep 17 00:00:00 2001
> From: Willy Tarreau <w@1wt.eu>
> Date: Sat, 25 Nov 2006 22:11:36 +0100
> Subject: [PATCH] e100: incorrect use of "&&" instead of "&"
> 
> In e100_do_ethtool_ioctl(), bdp->flags is a bitfield and is
> checked for some bits but the AND operation is performed with
> && instead of &. Obvious fix is to use "&" as in all other
> places. 2.6 does not seem affected.
> 
> Signed-off-by: Willy Tarreau <w@1wt.eu>
> ---
>  drivers/net/e100/e100_main.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/e100/e100_main.c b/drivers/net/e100/e100_main.c
> index c9d801a..d67a145 100644
> --- a/drivers/net/e100/e100_main.c
> +++ b/drivers/net/e100/e100_main.c
> @@ -3292,11 +3292,11 @@ #ifdef	ETHTOOL_GPAUSEPARAM
>  		if ((bdp->flags & IS_BACHELOR)
>  		    && (bdp->params.b_params & PRM_FC)) {
>  			epause.autoneg = 1;
> -			if (bdp->flags && DF_LINK_FC_CAP) {
> +			if (bdp->flags & DF_LINK_FC_CAP) {
>  				epause.rx_pause = 1;
>  				epause.tx_pause = 1;
>  			}
> -			if (bdp->flags && DF_LINK_FC_TX_ONLY)
> +			if (bdp->flags & DF_LINK_FC_TX_ONLY)
>  				epause.tx_pause = 1;
>  		}
>  		rc = copy_to_user(ifr->ifr_data, &epause, sizeof(epause))

Re: [PATCH-2.4] e100: incorrect use of "&&" instead of "&"

[Willy Tarreau]

Hi Auke,

On Mon, Nov 27, 2006 at 09:31:34AM -0800, Auke Kok wrote:
> Willy Tarreau wrote:
> >Hi guys,
> >
> >I'm about to apply this fix to 2.4. 2.6 is not affected.
> >Do you have any objection ?
> 
> Willy,
> 
> you didn't CC netdev. linux-net is a users list, you didn't CC the 
> maintainers of the driver. Please do this. We're more than happy to help, 
> even for 2.4 kernels.

I'm really sorry, as I usually use netdev and not linux-net. I don't know
why I used this one in the first step. There might have been some fog
inside my head.

BTW, there's no clear maintainer identified for e100. At best I can find
"linux.nics@intel.com" in the file, without any freshness info. Is that
still OK or do you want to update the MAINTAINERS file ?

> Patch looks good, please apply.
> 
> Acked-by: Auke Kok <auke-jan.h.kok@intel.com>

Done, thanks !

Willy

Re: [PATCH-2.4] e100: incorrect use of "&&" instead of "&"

[Auke Kok]

Willy Tarreau wrote:
> Hi Auke,
> 
> On Mon, Nov 27, 2006 at 09:31:34AM -0800, Auke Kok wrote:
>> Willy Tarreau wrote:
>>> Hi guys,
>>>
>>> I'm about to apply this fix to 2.4. 2.6 is not affected.
>>> Do you have any objection ?
>> Willy,
>>
>> you didn't CC netdev. linux-net is a users list, you didn't CC the 
>> maintainers of the driver. Please do this. We're more than happy to help, 
>> even for 2.4 kernels.
> 
> I'm really sorry, as I usually use netdev and not linux-net. I don't know
> why I used this one in the first step. There might have been some fog
> inside my head.
> 
> BTW, there's no clear maintainer identified for e100. At best I can find
> "linux.nics@intel.com" in the file, without any freshness info. Is that
> still OK or do you want to update the MAINTAINERS file ?

I'll post a patch for it, it's definately out of date :(

Auke