netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 2.6.18] declance: Support the I/O ASIC LANCE w/o TURBOchannel
@ 2006-11-30 13:15 Maciej W. Rozycki
  2006-12-02  5:19 ` Jeff Garzik
  0 siblings, 1 reply; 4+ messages in thread
From: Maciej W. Rozycki @ 2006-11-30 13:15 UTC (permalink / raw)
  To: Andrew Morton, Jeff Garzik; +Cc: netdev, linux-mips

 The onboard LANCE of I/O ASIC systems is not a TURBOchannel device, at 
least from the software point of view.  Therefore it does not rely on any 
kernel TURBOchannel bus services and can be supported even if support for 
TURBOchannel has not been enabled in the configuration.

Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
---
 Tested with the onboard LANCE of a DECstation 5000/133.

 Please apply.

  Maciej

patch-mips-2.6.18-20060920-declance-tc-0
diff -up --recursive --new-file linux-mips-2.6.18-20060920.macro/drivers/net/declance.c linux-mips-2.6.18-20060920/drivers/net/declance.c
--- linux-mips-2.6.18-20060920.macro/drivers/net/declance.c	2006-11-23 02:55:34.000000000 +0000
+++ linux-mips-2.6.18-20060920/drivers/net/declance.c	2006-11-30 02:31:19.000000000 +0000
@@ -1068,7 +1068,6 @@ static int __init dec_lance_init(const i
 	lp->type = type;
 	lp->slot = slot;
 	switch (type) {
-#ifdef CONFIG_TC
 	case ASIC_LANCE:
 		dev->base_addr = CKSEG1ADDR(dec_kn_slot_base + IOASIC_LANCE);
 
@@ -1112,7 +1111,7 @@ static int __init dec_lance_init(const i
 			     CPHYSADDR(dev->mem_start) << 3);
 
 		break;
-
+#ifdef CONFIG_TC
 	case PMAD_LANCE:
 		claim_tc_card(slot);
 
@@ -1143,7 +1142,6 @@ static int __init dec_lance_init(const i
 
 		break;
 #endif
-
 	case PMAX_LANCE:
 		dev->irq = dec_interrupt[DEC_IRQ_LANCE];
 		dev->base_addr = CKSEG1ADDR(KN01_SLOT_BASE + KN01_LANCE);
@@ -1298,10 +1296,8 @@ static int __init dec_lance_probe(void)
 	/* Then handle onboard devices. */
 	if (dec_interrupt[DEC_IRQ_LANCE] >= 0) {
 		if (dec_interrupt[DEC_IRQ_LANCE_MERR] >= 0) {
-#ifdef CONFIG_TC
 			if (dec_lance_init(ASIC_LANCE, -1) >= 0)
 				count++;
-#endif
 		} else if (!TURBOCHANNEL) {
 			if (dec_lance_init(PMAX_LANCE, -1) >= 0)
 				count++;

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2.6.18] declance: Support the I/O ASIC LANCE w/o TURBOchannel
  2006-11-30 13:15 [PATCH 2.6.18] declance: Support the I/O ASIC LANCE w/o TURBOchannel Maciej W. Rozycki
@ 2006-12-02  5:19 ` Jeff Garzik
  2006-12-02  5:46   ` Andrew Morton
  0 siblings, 1 reply; 4+ messages in thread
From: Jeff Garzik @ 2006-12-02  5:19 UTC (permalink / raw)
  To: Maciej W. Rozycki; +Cc: Andrew Morton, netdev, linux-mips

Maciej W. Rozycki wrote:
>  The onboard LANCE of I/O ASIC systems is not a TURBOchannel device, at 
> least from the software point of view.  Therefore it does not rely on any 
> kernel TURBOchannel bus services and can be supported even if support for 
> TURBOchannel has not been enabled in the configuration.
> 
> Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>

can you (or Andrew) please resend your patches against 2.6.19?

	Jeff




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2.6.18] declance: Support the I/O ASIC LANCE w/o TURBOchannel
  2006-12-02  5:19 ` Jeff Garzik
@ 2006-12-02  5:46   ` Andrew Morton
  2006-12-04 12:06     ` Maciej W. Rozycki
  0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2006-12-02  5:46 UTC (permalink / raw)
  To: Jeff Garzik; +Cc: Maciej W. Rozycki, netdev, linux-mips

On Sat, 02 Dec 2006 00:19:58 -0500
Jeff Garzik <jgarzik@pobox.com> wrote:

> Maciej W. Rozycki wrote:
> >  The onboard LANCE of I/O ASIC systems is not a TURBOchannel device, at 
> > least from the software point of view.  Therefore it does not rely on any 
> > kernel TURBOchannel bus services and can be supported even if support for 
> > TURBOchannel has not been enabled in the configuration.
> > 
> > Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
> 
> can you (or Andrew) please resend your patches against 2.6.19?
> 

I have then all (I think) queued up.  Will send once I've done a round
of build-testing.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2.6.18] declance: Support the I/O ASIC LANCE w/o TURBOchannel
  2006-12-02  5:46   ` Andrew Morton
@ 2006-12-04 12:06     ` Maciej W. Rozycki
  0 siblings, 0 replies; 4+ messages in thread
From: Maciej W. Rozycki @ 2006-12-04 12:06 UTC (permalink / raw)
  To: Andrew Morton; +Cc: Jeff Garzik, netdev, linux-mips

On Fri, 1 Dec 2006, Andrew Morton wrote:

> > can you (or Andrew) please resend your patches against 2.6.19?
> > 
> 
> I have then all (I think) queued up.  Will send once I've done a round
> of build-testing.

 Thanks a lot, Andrew.

  Maciej

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2006-12-04 12:06 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-30 13:15 [PATCH 2.6.18] declance: Support the I/O ASIC LANCE w/o TURBOchannel Maciej W. Rozycki
2006-12-02  5:19 ` Jeff Garzik
2006-12-02  5:46   ` Andrew Morton
2006-12-04 12:06     ` Maciej W. Rozycki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).