From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from proxima.lasnet.de (proxima.lasnet.de [78.47.171.185]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D45472CA7; Tue, 9 Jan 2024 07:30:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=datenfreihafen.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=datenfreihafen.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=datenfreihafen.org header.i=@datenfreihafen.org header.b="Oe5pkjpg" Received: from [192.168.2.51] (p4fe71516.dip0.t-ipconnect.de [79.231.21.22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: stefan@datenfreihafen.org) by proxima.lasnet.de (Postfix) with ESMTPSA id AF4D2C0A59; Tue, 9 Jan 2024 08:25:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=datenfreihafen.org; s=2021; t=1704785122; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VNe9ZlBCrsGQDNGRO/EZYFgSAuSM/viVxnwrUNsgIog=; b=Oe5pkjpgoKtGNFVYkuPB99brMpJOImAsWBaA2eqU5WenfyHYMW/iExHsG3KdCmcR7asSQS Lg8VXIGL/72NQT5t8Njvky4asduboskvoh7LvGqo5QqAVFjCxJd1+bF51/6f4Nl6QpIPLd IOrKnZ5aTYyhcvr82Jr+4jiQTOI6FjJ5nVo8ZpVGs4Idyva6rViUn8vDD9qREyYB1ZCO2g eglJUHJXUIUFgZhKH7uaLmC/splfX5LkMwIYq46Du9Cfz6y8IFzlb5hA6nwP4GO4M9ATD2 58aiPeK/8ESezJgCVfcTgc1kry/iiAbC6h67PC4hnYdiVW+rGJDySR+wlm2jmQ== Message-ID: <45711bec-e0f3-43c2-b8f2-b9a55654710b@datenfreihafen.org> Date: Tue, 9 Jan 2024 08:25:21 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 06/10] net: fill in MODULE_DESCRIPTION()s for ieee802154 Content-Language: en-US To: Breno Leitao , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, Alexander Aring , Miquel Raynal Cc: netdev@vger.kernel.org, "open list:IEEE 802.15.4 SUBSYSTEM" , open list References: <20240108181610.2697017-1-leitao@debian.org> <20240108181610.2697017-7-leitao@debian.org> From: Stefan Schmidt In-Reply-To: <20240108181610.2697017-7-leitao@debian.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello. On 08.01.24 19:16, Breno Leitao wrote: > W=1 builds now warn if module is built without a MODULE_DESCRIPTION(). > Add descriptions to ieee802154 modules. > > Signed-off-by: Breno Leitao > --- > net/ieee802154/6lowpan/core.c | 1 + > net/ieee802154/socket.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/net/ieee802154/6lowpan/core.c b/net/ieee802154/6lowpan/core.c > index 2c087b7f17c5..b88f6a96d961 100644 > --- a/net/ieee802154/6lowpan/core.c > +++ b/net/ieee802154/6lowpan/core.c > @@ -280,5 +280,6 @@ static void __exit lowpan_cleanup_module(void) > > module_init(lowpan_init_module); > module_exit(lowpan_cleanup_module); > +MODULE_DESCRIPTION("IPv6 over Low power Wireless Personal Area Network IEEE802154.4 core"); If we want to nitpick you could write it as IEEE 802.15.4. > MODULE_LICENSE("GPL"); > MODULE_ALIAS_RTNL_LINK("lowpan"); > diff --git a/net/ieee802154/socket.c b/net/ieee802154/socket.c > index 00302e8b9615..db8df6e26159 100644 > --- a/net/ieee802154/socket.c > +++ b/net/ieee802154/socket.c > @@ -1137,4 +1137,5 @@ module_init(af_ieee802154_init); > module_exit(af_ieee802154_remove); > > MODULE_LICENSE("GPL"); > +MODULE_DESCRIPTION("IEEE802154.4 socket interface"); > MODULE_ALIAS_NETPROTO(PF_IEEE802154); Same here. Besides this: Acked-by: Stefan Schmidt regards Stefan Schmidt