From: Brice Goglin <brice@myri.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: netdev@vger.kernel.org
Subject: [PATCH 1/1] myri10ge: write as 2 32-byte blocks in myri10ge_submit_8rx
Date: Mon, 04 Dec 2006 11:33:31 +0100 [thread overview]
Message-ID: <4573F97B.90707@myri.com> (raw)
In-Reply-To: <4573F8ED.3050304@myri.com>
In the myri10ge_submit_8rx() routine, write the 64 byte request block as
2 32-byte blocks so that it is handled by the hardware pio write handler
if write-combining is enabled.
Signed-off-by: Brice Goglin <brice@myri.com>
---
drivers/net/myri10ge/myri10ge.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Index: linux-2.6.19/drivers/net/myri10ge/myri10ge.c
===================================================================
--- linux-2.6.19.orig/drivers/net/myri10ge/myri10ge.c 2006-11-29 22:57:37.000000000 +0100
+++ linux-2.6.19/drivers/net/myri10ge/myri10ge.c 2006-12-04 11:22:48.000000000 +0100
@@ -790,7 +790,9 @@
low = src->addr_low;
src->addr_low = DMA_32BIT_MASK;
- myri10ge_pio_copy(dst, src, 8 * sizeof(*src));
+ myri10ge_pio_copy(dst, src, 4 * sizeof(*src));
+ mb();
+ myri10ge_pio_copy(dst + 4, src + 4, 4 * sizeof(*src));
mb();
src->addr_low = low;
__raw_writel(low, &dst->addr_low);
next prev parent reply other threads:[~2006-12-04 10:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-04 10:31 [PATCH 0/1] small myri10ge fix for 2.6.20 Brice Goglin
2006-12-04 10:33 ` Brice Goglin [this message]
2006-12-04 23:36 ` [PATCH 1/1] myri10ge: write as 2 32-byte blocks in myri10ge_submit_8rx Jeff Garzik
2006-12-05 15:28 ` Brice Goglin
2006-12-05 16:26 ` Brice Goglin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4573F97B.90707@myri.com \
--to=brice@myri.com \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).