From: Patrick McHardy <kaber@trash.net>
To: hadi@cyberus.ca
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH][XFRM] Optimize policy dumping
Date: Mon, 04 Dec 2006 18:59:31 +0100 [thread overview]
Message-ID: <45746203.2030400@trash.net> (raw)
In-Reply-To: <1165254213.3643.25.camel@localhost>
jamal wrote:
> Ok, both looked good except for the test of a single entry.
> This was because you would break out of the loop with count of 0.
> The patch against yours would look like something attached for the state
> case. Dont forget there are two spots on the policy side of things;->
You're right, that case was also broken. With your patch on top
it looks all right.
> You can either submit both patches or i could later today. If you do,
> please look at some of the comments i made in the first patch and
> include them.
I'd prefer if you did it since you're already testing the thing :)
next prev parent reply other threads:[~2006-12-04 17:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-03 15:11 [PATCH][XFRM] Optimize policy dumping jamal
2006-12-04 12:24 ` Patrick McHardy
2006-12-04 13:26 ` jamal
2006-12-04 13:52 ` Patrick McHardy
2006-12-04 13:57 ` Patrick McHardy
2006-12-04 13:58 ` jamal
2006-12-04 14:05 ` jamal
2006-12-04 15:37 ` jamal
2006-12-04 15:55 ` Patrick McHardy
2006-12-04 15:57 ` Patrick McHardy
2006-12-04 17:43 ` jamal
2006-12-04 17:59 ` Patrick McHardy [this message]
2006-12-04 20:46 ` jamal
2006-12-04 14:06 ` Patrick McHardy
2006-12-04 14:11 ` jamal
2006-12-04 14:26 ` Patrick McHardy
-- strict thread matches above, loose matches on Subject: below --
2006-12-04 20:58 jamal
2006-12-05 4:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45746203.2030400@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).