From: Patrick McHardy <kaber@trash.net>
To: Jarek Poplawski <jarkao2@o2.pl>
Cc: Linux Netdev List <netdev@vger.kernel.org>,
Thomas Graf <tgraf@suug.ch>, jamal <hadi@cyberus.ca>
Subject: Re: [NET_SCHED]: cls_fw: fix NULL pointer dereference
Date: Wed, 06 Dec 2006 18:17:50 +0100 [thread overview]
Message-ID: <4576FB3E.8000702@trash.net> (raw)
In-Reply-To: <20061206131807.GA2858@ff.dom.local>
Jarek Poplawski wrote:
> On 04-12-2006 16:34, Patrick McHardy wrote:
>
>>Thomas, Jamal, do you have an idea what this "old method" stuff
>>is used for? It seems it is only used during the below mentioned
>>race.
>
>
> Sorry for eavesdropping, but have a look at htb_classify
> starting comment. It is also used by unofficial but quite
> popular IPMARK target.
Yes I know, I just didn't see how it could be configured to
really use that code. But while trying to explain the flow
that would always lead to tp->root != NULL in this mail, I
noticed I missed something :)
At the top of fw_change:
if (!opt)
return handle ? -EINVAL : 0;
which happens when adding a fw classifier without specifying any
arguments. My previous fix is still enough, but we can't remove
this of course.
prev parent reply other threads:[~2006-12-06 17:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-04 15:34 [NET_SCHED]: cls_fw: fix NULL pointer dereference Patrick McHardy
2006-12-04 16:25 ` jamal
2006-12-04 16:28 ` Thomas Graf
2006-12-04 16:39 ` Patrick McHardy
2006-12-04 16:59 ` Thomas Graf
2006-12-05 21:46 ` David Miller
2006-12-06 13:18 ` Jarek Poplawski
2006-12-06 17:17 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4576FB3E.8000702@trash.net \
--to=kaber@trash.net \
--cc=hadi@cyberus.ca \
--cc=jarkao2@o2.pl \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).