From: Rick Jones <rick.jones2@hp.com>
To: David Miller <davem@davemloft.net>
Cc: shemminger@osdl.org, muli@il.ibm.com, jeff@garzik.org,
amitkale@netxen.com, netdev@vger.kernel.org,
brazilnut@us.ibm.com, netxenproj@linsyssoft.com, rob@netxen.com,
romieu@fr.zoreil.com, sanjeev@netxen.com, wendyx@us.ibm.com
Subject: Re: network devices don't handle pci_dma_mapping_error()'s
Date: Wed, 06 Dec 2006 18:18:52 -0800 [thread overview]
Message-ID: <45777A0C.4010901@hp.com> (raw)
In-Reply-To: <20061206.171317.85392745.davem@davemloft.net>
David Miller wrote:
> From: Stephen Hemminger <shemminger@osdl.org>
> Date: Wed, 6 Dec 2006 16:58:35 -0800
>
>
>>The more robust way would be to stop the queue (like flow control)
>>and return busy. You would need a timer though to handle the case
>>where some disk i/o stole all the mappings and then network device flow
>>blocked.
>
>
> You need some kind of fairness, yes, that's why I suggested a
> callback. When your DMA allocation fails, you get into the rear of
> the FIFO, when a free occurs, we callback starting from the head of
> the FIFO. You don't get removed from the FIFO unless at least one of
> your DMA allocation retries succeed.
While tossing a TCP|UDP|SCTP|etc packet could be plusungood, especially
if the IOMMU fills frequently (for some suitable definiton of
frequently), is it really worth the effort to save say an ACK?
rick jones
next prev parent reply other threads:[~2006-12-07 2:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-01 13:40 [PATCH 2/3] NetXen: 64-bit memory fixes Amit S. Kale
2006-12-01 18:56 ` Stephen Hemminger
2006-12-02 5:32 ` Jeff Garzik
2006-12-04 18:39 ` network devices don't handle pci_dma_mapping_error()'s Stephen Hemminger
2006-12-05 7:00 ` Muli Ben-Yehuda
2006-12-06 18:16 ` Stephen Hemminger
2006-12-06 19:33 ` Muli Ben-Yehuda
2006-12-07 6:18 ` Amit S. Kale
2006-12-07 13:04 ` Muli Ben-Yehuda
2006-12-07 0:54 ` David Miller
2006-12-07 0:58 ` Stephen Hemminger
2006-12-07 1:13 ` David Miller
2006-12-07 2:18 ` Rick Jones [this message]
2006-12-07 2:31 ` David Miller
2006-12-07 6:25 ` Amit S. Kale
2006-12-07 6:46 ` Stephen Hemminger
2006-12-07 6:55 ` Amit S. Kale
2006-12-07 7:24 ` David Miller
2006-12-07 20:07 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45777A0C.4010901@hp.com \
--to=rick.jones2@hp.com \
--cc=amitkale@netxen.com \
--cc=brazilnut@us.ibm.com \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=muli@il.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=netxenproj@linsyssoft.com \
--cc=rob@netxen.com \
--cc=romieu@fr.zoreil.com \
--cc=sanjeev@netxen.com \
--cc=shemminger@osdl.org \
--cc=wendyx@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).