From: Brice Goglin <brice@myri.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: Jeff Garzik <jgarzik@pobox.com>, netdev@vger.kernel.org
Subject: Re: [PATCH] myri10ge: pci msi and express state save/restore
Date: Fri, 08 Dec 2006 18:28:07 +0100 [thread overview]
Message-ID: <4579A0A7.6090304@myri.com> (raw)
In-Reply-To: <20061208085231.7aec5ce3@dxpl.pdx.osdl.net>
It looks ok to me, except that you should also remove devctl and
msi_flags from myri10ge_priv since these fields were only used in the
functions that are dropped by this patch.
However, I won't be able to test the patch on real hardware within the
next days...
Thanks a lot!
Brice
Stephen Hemminger wrote:
> The PCI MSI and express state are already saved and restored by the
> current versions of pci_save_state/pci_restore_state.
> Therefore it should no longer be necessary for the driver to do it.
> This patch has not been tested on the hardware.
>
> On suspend, handle pci_set_power_state errors, and on resume
> handle failures in pci_resume_state().
>
> Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
>
> ---
> drivers/net/myri10ge/myri10ge.c | 48 +++++++++-------------------------------
> 1 file changed, 11 insertions(+), 37 deletions(-)
>
next prev parent reply other threads:[~2006-12-08 17:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-08 16:52 [PATCH] myri10ge: pci msi and express state save/restore Stephen Hemminger
2006-12-08 17:28 ` Brice Goglin [this message]
2006-12-11 14:29 ` Jeff Garzik
2006-12-11 14:41 ` Brice Goglin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4579A0A7.6090304@myri.com \
--to=brice@myri.com \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).