From: Jeff Garzik <jgarzik@pobox.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: Brice Goglin <brice@myri.com>, netdev@vger.kernel.org
Subject: Re: [PATCH] myri10ge: pci msi and express state save/restore
Date: Mon, 11 Dec 2006 09:29:09 -0500 [thread overview]
Message-ID: <457D6B35.8000801@pobox.com> (raw)
In-Reply-To: <20061208085231.7aec5ce3@dxpl.pdx.osdl.net>
Stephen Hemminger wrote:
> The PCI MSI and express state are already saved and restored by the
> current versions of pci_save_state/pci_restore_state.
> Therefore it should no longer be necessary for the driver to do it.
> This patch has not been tested on the hardware.
>
> On suspend, handle pci_set_power_state errors, and on resume
> handle failures in pci_resume_state().
>
> Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Since Brice is an active maintainer, I would prefer to receive this
patch via Brice. I have a pile of patches from him, and don't want to
invalidate that pile for this patch, even though this patch looks fairly
sane to me.
Jeff
next prev parent reply other threads:[~2006-12-11 14:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-08 16:52 [PATCH] myri10ge: pci msi and express state save/restore Stephen Hemminger
2006-12-08 17:28 ` Brice Goglin
2006-12-11 14:29 ` Jeff Garzik [this message]
2006-12-11 14:41 ` Brice Goglin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=457D6B35.8000801@pobox.com \
--to=jgarzik@pobox.com \
--cc=brice@myri.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).