From: Auke Kok <auke-jan.h.kok@intel.com>
To: Yan Burman <burman.yan@gmail.com>
Cc: linux-kernel@vger.kernel.org, trivial@kernel.org,
john.ronciak@intel.com, NetDev <netdev@vger.kernel.org>,
Jeff Garzik <jgarzik@pobox.com>
Subject: Re: [PATCH 2.6.19] e100: replace kmalloc with kcalloc
Date: Tue, 12 Dec 2006 10:34:26 -0800 [thread overview]
Message-ID: <457EF632.4060106@intel.com> (raw)
In-Reply-To: <1165942531.5611.7.camel@localhost>
Yan Burman wrote:
> Replace kmalloc+memset with kcalloc
ACK, fine with me.
> Signed-off-by: Yan Burman <burman.yan@gmail.com>
>
> diff -rubp linux-2.6.19-rc5_orig/drivers/net/e100.c linux-2.6.19-rc5_kzalloc/drivers/net/e100.c
> --- linux-2.6.19-rc5_orig/drivers/net/e100.c 2006-11-09 12:16:21.000000000 +0200
> +++ linux-2.6.19-rc5_kzalloc/drivers/net/e100.c 2006-11-11 22:44:04.000000000 +0200
> @@ -1930,9 +1930,8 @@ static int e100_rx_alloc_list(struct nic
> nic->rx_to_use = nic->rx_to_clean = NULL;
> nic->ru_running = RU_UNINITIALIZED;
>
> - if(!(nic->rxs = kmalloc(sizeof(struct rx) * count, GFP_ATOMIC)))
> + if(!(nic->rxs = kcalloc(count, sizeof(struct rx), GFP_ATOMIC)))
> return -ENOMEM;
> - memset(nic->rxs, 0, sizeof(struct rx) * count);
>
> for(rx = nic->rxs, i = 0; i < count; rx++, i++) {
> rx->next = (i + 1 < count) ? rx + 1 : nic->rxs;
>
>
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
parent reply other threads:[~2006-12-12 18:34 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1165942531.5611.7.camel@localhost>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=457EF632.4060106@intel.com \
--to=auke-jan.h.kok@intel.com \
--cc=burman.yan@gmail.com \
--cc=jgarzik@pobox.com \
--cc=john.ronciak@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).