[PATCH 2.6.18 2/2] LARTC: trace control for netem: kernelspace

[PATCH 2.6.18 2/2] LARTC: trace control for netem: kernelspace

[Rainer Baumann]

Trace Control for Netem: Emulate network properties such as long range dependency and self-similarity of cross-traffic.

kernel space:
The delay, drop, duplication and corruption values are readout in user space and sent to kernel space via configfs. The userspace process will "hang on write" until the kernel needs new data.

In order to have always packet action values ready to apply, there are two buffers that hold these values. Packet action values can be read from one buffer and the other buffer can be refilled with new values simultaneously. The synchronization of "need more delay values" and "return from write" is done with the use of wait queues.

Having applied the delay value to a packet, the packet gets processed by the original netem functions.

Signed-off-by: Rainer Baumann <baumann@tik.ee.ethz.ch>

---

Patch for linux kernel 2.6.18.13: http://tcn.hypert.net/tcn_kernel_configfs.patch

Re: [PATCH 2.6.18 2/2] LARTC: trace control for netem: kernelspace

[Hagen Paul Pfeifer]

* Rainer Baumann | 2006-12-15 11:39:28 [+0100]:

>Patch for linux kernel 2.6.18.13:
>http://tcn.hypert.net/tcn_kernel_configfs.patch

This patch isn't ok ( maybe this patch benefit from gcc padding behaviours):

static struct pktdelay get_next_delay(struct netem_sched_data *q)
{
  struct pktdelay retval;

  [...]

  return retval;
}

There are also some tiny coding style issues.


Hagen

PS: please setup you mua to break lines - it's a little bit difficult to read
you mails

Re: [PATCH 2.6.18 2/2] LARTC: trace control for netem: kernelspace

[Hagen Paul Pfeifer]

>This patch isn't ok ( maybe this patch benefit from gcc padding behaviours):

Ignore this - I thought this function returns a pointer ... 
(take a look at my email signature :-)

HGN



-- 
COFFEE.EXE Missing - Insert Cup and Press Any Key.