* [PATCH] Marvell Libertas 8388 802.11b/g USB driver @ 2006-12-15 22:51 Marcelo Tosatti 2006-12-16 2:52 ` Michael Wu 0 siblings, 1 reply; 6+ messages in thread From: Marcelo Tosatti @ 2006-12-15 22:51 UTC (permalink / raw) To: netdev Cc: Jeff Garzik, Dan Williams, Luis R. Rodriguez, Arnd Bergmann, John W. Linville Hi, Marvell released a GPL driver for their 8388 wireless chip for USB interface back in April. The 8388 is the device being used by the OLPC laptop. We have been working on cleaning it up for mainline inclusion. I think the moment for wider review has arrived. Since the diff is pretty large (700K) I've put it on the web at: http://dev.laptop.org/~marcelo/libertas-8388-15122006.patch And its GIT tree resides at: http://git.infradead.org/?p=libertas-2.6.git;a=log Comments are welcome ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver 2006-12-15 22:51 [PATCH] Marvell Libertas 8388 802.11b/g USB driver Marcelo Tosatti @ 2006-12-16 2:52 ` Michael Wu 2006-12-16 3:03 ` David Young 0 siblings, 1 reply; 6+ messages in thread From: Michael Wu @ 2006-12-16 2:52 UTC (permalink / raw) To: Marcelo Tosatti Cc: netdev, Jeff Garzik, Dan Williams, Luis R. Rodriguez, Arnd Bergmann, John W. Linville, dyoung [-- Attachment #1: Type: text/plain, Size: 1683 bytes --] On Friday 15 December 2006 17:51, Marcelo Tosatti wrote: >--- a/include/net/ieee80211_radiotap.h >+++ b/include/net/ieee80211_radiotap.h >@@ -168,6 +168,23 @@ struct ieee80211_radiotap_header { > * Unitless indication of the Rx/Tx antenna for this packet. > * The first antenna is antenna 0. > * >+ * IEEE80211_RADIOTAP_RX_FLAGS u_int16_t bitmap >+ * >+ * Properties of received frames. See flags defined below. >+ * >+ * IEEE80211_RADIOTAP_TX_FLAGS u_int16_t bitmap >+ * >+ * Properties of transmitted frames. See flags defined below. >+ * >+ * IEEE80211_RADIOTAP_RTS_RETRIES u_int8_t data >+ * >+ * Number of rts retries a transmitted frame used. >+ * >+ * IEEE80211_RADIOTAP_DATA_RETRIES u_int8_t data >+ * >+ * Number of unicast retries a transmitted frame used. >+ * >+ * > * IEEE80211_RADIOTAP_FCS u32 data > * > * FCS from frame in network byte order. >@@ -187,7 +204,11 @@ enum ieee80211_radiotap_type { > IEEE80211_RADIOTAP_ANTENNA = 11, > IEEE80211_RADIOTAP_DB_ANTSIGNAL = 12, > IEEE80211_RADIOTAP_DB_ANTNOISE = 13, >- IEEE80211_RADIOTAP_EXT = 31, >+ IEEE80211_RADIOTAP_RX_FLAGS = 14, >+ IEEE80211_RADIOTAP_TX_FLAGS = 15, >+ IEEE80211_RADIOTAP_RTS_RETRIES = 16, >+ IEEE80211_RADIOTAP_DATA_RETRIES = 17, >+ IEEE80211_RADIOTAP_EXT = 31 > }; > > /* Channel flags. */ Did you send this part to netbsd also? We really don't want to fork radiotap. ;) Also, this should be in a separate patch, but I'm guessing it's all rolled together for convenience. -Michael Wu [-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver 2006-12-16 2:52 ` Michael Wu @ 2006-12-16 3:03 ` David Young 2006-12-16 3:55 ` Sam Leffler [not found] ` <20061218195723.GB7260@dmt> 0 siblings, 2 replies; 6+ messages in thread From: David Young @ 2006-12-16 3:03 UTC (permalink / raw) To: Michael Wu Cc: Marcelo Tosatti, netdev, Jeff Garzik, Dan Williams, Luis R. Rodriguez, Arnd Bergmann, John W. Linville On Fri, Dec 15, 2006 at 09:52:20PM -0500, Michael Wu wrote: > On Friday 15 December 2006 17:51, Marcelo Tosatti wrote: > >--- a/include/net/ieee80211_radiotap.h > >+++ b/include/net/ieee80211_radiotap.h > >@@ -168,6 +168,23 @@ struct ieee80211_radiotap_header { > > * Unitless indication of the Rx/Tx antenna for this packet. > > * The first antenna is antenna 0. > > * > >+ * IEEE80211_RADIOTAP_RX_FLAGS u_int16_t bitmap > >+ * > >+ * Properties of received frames. See flags defined below. > >+ * > >+ * IEEE80211_RADIOTAP_TX_FLAGS u_int16_t bitmap > >+ * > >+ * Properties of transmitted frames. See flags defined below. > >+ * > >+ * IEEE80211_RADIOTAP_RTS_RETRIES u_int8_t data > >+ * > >+ * Number of rts retries a transmitted frame used. > >+ * > >+ * IEEE80211_RADIOTAP_DATA_RETRIES u_int8_t data > >+ * > >+ * Number of unicast retries a transmitted frame used. > >+ * > >+ * > > * IEEE80211_RADIOTAP_FCS u32 data > > * > > * FCS from frame in network byte order. > >@@ -187,7 +204,11 @@ enum ieee80211_radiotap_type { > > IEEE80211_RADIOTAP_ANTENNA = 11, > > IEEE80211_RADIOTAP_DB_ANTSIGNAL = 12, > > IEEE80211_RADIOTAP_DB_ANTNOISE = 13, > >- IEEE80211_RADIOTAP_EXT = 31, > >+ IEEE80211_RADIOTAP_RX_FLAGS = 14, > >+ IEEE80211_RADIOTAP_TX_FLAGS = 15, > >+ IEEE80211_RADIOTAP_RTS_RETRIES = 16, > >+ IEEE80211_RADIOTAP_DATA_RETRIES = 17, > >+ IEEE80211_RADIOTAP_EXT = 31 > > }; > > > > /* Channel flags. */ > Did you send this part to netbsd also? We really don't want to fork > radiotap. ;) Also, this should be in a separate patch, but I'm guessing it's > all rolled together for convenience. No, especially since NetBSD is where I keep the authoritative definitions. How have you defined RX_FLAGS and TX_FLAGS? BTW, IEEE80211_RADIOTAP_FCS (above) never made it into radiotap. No bit is reserved. Dave -- David Young OJC Technologies dyoung@ojctech.com Urbana, IL * (217) 278-3933 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver 2006-12-16 3:03 ` David Young @ 2006-12-16 3:55 ` Sam Leffler 2006-12-16 4:20 ` Sam Leffler [not found] ` <20061218195723.GB7260@dmt> 1 sibling, 1 reply; 6+ messages in thread From: Sam Leffler @ 2006-12-16 3:55 UTC (permalink / raw) To: David Young Cc: Michael Wu, Marcelo Tosatti, netdev, Jeff Garzik, Dan Williams, Luis R. Rodriguez, Arnd Bergmann, John W. Linville David Young wrote: > On Fri, Dec 15, 2006 at 09:52:20PM -0500, Michael Wu wrote: >> On Friday 15 December 2006 17:51, Marcelo Tosatti wrote: >>> --- a/include/net/ieee80211_radiotap.h >>> +++ b/include/net/ieee80211_radiotap.h >>> @@ -168,6 +168,23 @@ struct ieee80211_radiotap_header { >>> * Unitless indication of the Rx/Tx antenna for this packet. >>> * The first antenna is antenna 0. >>> * >>> + * IEEE80211_RADIOTAP_RX_FLAGS u_int16_t bitmap >>> + * >>> + * Properties of received frames. See flags defined below. >>> + * >>> + * IEEE80211_RADIOTAP_TX_FLAGS u_int16_t bitmap >>> + * >>> + * Properties of transmitted frames. See flags defined below. >>> + * >>> + * IEEE80211_RADIOTAP_RTS_RETRIES u_int8_t data >>> + * >>> + * Number of rts retries a transmitted frame used. >>> + * >>> + * IEEE80211_RADIOTAP_DATA_RETRIES u_int8_t data >>> + * >>> + * Number of unicast retries a transmitted frame used. >>> + * >>> + * >>> * IEEE80211_RADIOTAP_FCS u32 data >>> * >>> * FCS from frame in network byte order. >>> @@ -187,7 +204,11 @@ enum ieee80211_radiotap_type { >>> IEEE80211_RADIOTAP_ANTENNA = 11, >>> IEEE80211_RADIOTAP_DB_ANTSIGNAL = 12, >>> IEEE80211_RADIOTAP_DB_ANTNOISE = 13, >>> - IEEE80211_RADIOTAP_EXT = 31, >>> + IEEE80211_RADIOTAP_RX_FLAGS = 14, >>> + IEEE80211_RADIOTAP_TX_FLAGS = 15, >>> + IEEE80211_RADIOTAP_RTS_RETRIES = 16, >>> + IEEE80211_RADIOTAP_DATA_RETRIES = 17, >>> + IEEE80211_RADIOTAP_EXT = 31 >>> }; >>> >>> /* Channel flags. */ >> Did you send this part to netbsd also? We really don't want to fork >> radiotap. ;) Also, this should be in a separate patch, but I'm guessing it's >> all rolled together for convenience. > > No, especially since NetBSD is where I keep the authoritative definitions. > > How have you defined RX_FLAGS and TX_FLAGS? > > BTW, IEEE80211_RADIOTAP_FCS (above) never made it into radiotap. No bit > is reserved. Tell that to everyone that implements it. Sam ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver 2006-12-16 3:55 ` Sam Leffler @ 2006-12-16 4:20 ` Sam Leffler 0 siblings, 0 replies; 6+ messages in thread From: Sam Leffler @ 2006-12-16 4:20 UTC (permalink / raw) To: David Young Cc: Michael Wu, Marcelo Tosatti, netdev, Jeff Garzik, Dan Williams, Luis R. Rodriguez, Arnd Bergmann, John W. Linville Sam Leffler wrote: > David Young wrote: >> On Fri, Dec 15, 2006 at 09:52:20PM -0500, Michael Wu wrote: >>> On Friday 15 December 2006 17:51, Marcelo Tosatti wrote: >>>> --- a/include/net/ieee80211_radiotap.h >>>> +++ b/include/net/ieee80211_radiotap.h >>>> @@ -168,6 +168,23 @@ struct ieee80211_radiotap_header { >>>> * Unitless indication of the Rx/Tx antenna for this packet. >>>> * The first antenna is antenna 0. >>>> * >>>> + * IEEE80211_RADIOTAP_RX_FLAGS u_int16_t bitmap >>>> + * >>>> + * Properties of received frames. See flags defined below. >>>> + * >>>> + * IEEE80211_RADIOTAP_TX_FLAGS u_int16_t bitmap >>>> + * >>>> + * Properties of transmitted frames. See flags defined below. >>>> + * >>>> + * IEEE80211_RADIOTAP_RTS_RETRIES u_int8_t data >>>> + * >>>> + * Number of rts retries a transmitted frame used. >>>> + * >>>> + * IEEE80211_RADIOTAP_DATA_RETRIES u_int8_t data >>>> + * >>>> + * Number of unicast retries a transmitted frame used. >>>> + * >>>> + * >>>> * IEEE80211_RADIOTAP_FCS u32 data >>>> * >>>> * FCS from frame in network byte order. >>>> @@ -187,7 +204,11 @@ enum ieee80211_radiotap_type { >>>> IEEE80211_RADIOTAP_ANTENNA = 11, >>>> IEEE80211_RADIOTAP_DB_ANTSIGNAL = 12, >>>> IEEE80211_RADIOTAP_DB_ANTNOISE = 13, >>>> - IEEE80211_RADIOTAP_EXT = 31, >>>> + IEEE80211_RADIOTAP_RX_FLAGS = 14, >>>> + IEEE80211_RADIOTAP_TX_FLAGS = 15, >>>> + IEEE80211_RADIOTAP_RTS_RETRIES = 16, >>>> + IEEE80211_RADIOTAP_DATA_RETRIES = 17, >>>> + IEEE80211_RADIOTAP_EXT = 31 >>>> }; >>>> >>>> /* Channel flags. */ >>> Did you send this part to netbsd also? We really don't want to fork >>> radiotap. ;) Also, this should be in a separate patch, but I'm guessing it's >>> all rolled together for convenience. >> No, especially since NetBSD is where I keep the authoritative definitions. >> >> How have you defined RX_FLAGS and TX_FLAGS? >> >> BTW, IEEE80211_RADIOTAP_FCS (above) never made it into radiotap. No bit >> is reserved. > > Tell that to everyone that implements it. > My mistake. David pointed out correctly that the mechanism for adding the FCS out-of-line (IEEE80211_RADIOTAP_FCS) was not used. Instead there is a flag bit that tells whether or not FCS is present (inline) in the data. This flag bit is what I was thinking of--it's honored by ethereal (aka wireshark), kismet, tcpdump, etc. Sam ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <20061218195723.GB7260@dmt>]
* Re: [PATCH] Marvell Libertas 8388 802.11b/g USB driver [not found] ` <20061218195723.GB7260@dmt> @ 2007-02-06 23:21 ` David Young 0 siblings, 0 replies; 6+ messages in thread From: David Young @ 2007-02-06 23:21 UTC (permalink / raw) To: Marcelo Tosatti Cc: Michael Wu, netdev, Jeff Garzik, Dan Williams, Luis R. Rodriguez, Arnd Bergmann, John W. Linville, sam On Mon, Dec 18, 2006 at 05:57:23PM -0200, Marcelo Tosatti wrote: > > > > > /* Channel flags. */ > > > Did you send this part to netbsd also? We really don't want to fork > > > radiotap. ;) Also, this should be in a separate patch, but I'm guessing it's > > > all rolled together for convenience. > > > > No, especially since NetBSD is where I keep the authoritative definitions. > > > > How have you defined RX_FLAGS and TX_FLAGS? > > Oh yes, missed that part of the patch. Sorry. Sorry for the delayed response, it's been a busy couple of months. There is now a mailing list for discussing radiotap. Subscribe at <http://mail.ojctech.com/mailman/listinfo/radiotap>. I ask that you send proposals for new fields to the mailing list for discussion. I am interested to see proposals for 802.11n. A couple of people have already promised me proposals, but they never sent them. A couple words about the fields you mention: > --- a/include/net/ieee80211_radiotap.h > +++ b/include/net/ieee80211_radiotap.h > @@ -168,6 +168,23 @@ struct ieee80211_radiotap_header { > * Unitless indication of the Rx/Tx antenna for this packet. > * The first antenna is antenna 0. > * > + * IEEE80211_RADIOTAP_RX_FLAGS u_int16_t bitmap > + * > + * Properties of received frames. See flags defined below. > + * > + * IEEE80211_RADIOTAP_TX_FLAGS u_int16_t bitmap > + * > + * Properties of transmitted frames. See flags defined below. > + * > + * IEEE80211_RADIOTAP_RTS_RETRIES u_int8_t data > + * > + * Number of rts retries a transmitted frame used. > + * > + * IEEE80211_RADIOTAP_DATA_RETRIES u_int8_t data > + * > + * Number of unicast retries a transmitted frame used. > + * > + * > * IEEE80211_RADIOTAP_FCS u32 data > * > * FCS from frame in network byte order. > @@ -187,7 +204,11 @@ enum ieee80211_radiotap_type { > IEEE80211_RADIOTAP_ANTENNA = 11, > IEEE80211_RADIOTAP_DB_ANTSIGNAL = 12, > IEEE80211_RADIOTAP_DB_ANTNOISE = 13, > - IEEE80211_RADIOTAP_EXT = 31, > + IEEE80211_RADIOTAP_RX_FLAGS = 14, > + IEEE80211_RADIOTAP_TX_FLAGS = 15, > + IEEE80211_RADIOTAP_RTS_RETRIES = 16, > + IEEE80211_RADIOTAP_DATA_RETRIES = 17, > + IEEE80211_RADIOTAP_EXT = 31 > }; I remember discussing these fields, but they were for somebody's experimental use. All of the fields are acceptable to me, but this flag is questionable; it duplicates the function of another flag: > +#define IEEE80211_RADIOTAP_F_RX_BADFCS 0x0001 /* frame failed crc check */ If it is important to people that I add this flag, let's discuss on the mailing list. Dave -- David Young OJC Technologies dyoung@ojctech.com Urbana, IL * (217) 278-3933 ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-02-07 0:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-15 22:51 [PATCH] Marvell Libertas 8388 802.11b/g USB driver Marcelo Tosatti
2006-12-16 2:52 ` Michael Wu
2006-12-16 3:03 ` David Young
2006-12-16 3:55 ` Sam Leffler
2006-12-16 4:20 ` Sam Leffler
[not found] ` <20061218195723.GB7260@dmt>
2007-02-06 23:21 ` David Young
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).