From: Jeff Garzik <jeff@garzik.org>
To: Ramkrishna Vepa <Ramkrishna.Vepa@neterion.com>
Cc: Ralf Baechle <ralf@linux-mips.org>, netdev@vger.kernel.org
Subject: Re: [S2IO] De-typedef driver
Date: Sat, 16 Dec 2006 11:39:46 -0500 [thread overview]
Message-ID: <45842152.10408@garzik.org> (raw)
In-Reply-To: <78C9135A3D2ECE4B8162EBDCE82CAD77010097D1@nekter>
Ramkrishna Vepa wrote:
>> I stomped over the s2io driver when doing an allyesconfig build for
> IP27
>> where there was a namespace collision between the IP27 code and the
> s2io
>> driver which both use a nic_t. I decieded both were broken, IP27
> should
>> not export the type and s2io was a totally typedef polluted piece of
> code.
>> So here's the s2io part of the fix.
> [Ram] Agreed this is a problem. Please leave the typedef but change
> nic_t to xframe_t. This will make it unique and is a much simpler
> change.
More simple yes, but not any closer to the Linux kernel (and POSIX)
preferred style.
Most kernel devs' brains work better after applying Ralf's patch...
Jeff
next prev parent reply other threads:[~2006-12-16 16:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-11 18:39 [S2IO] De-typedef driver Ramkrishna Vepa
2006-12-16 16:39 ` Jeff Garzik [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-12-11 16:53 Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45842152.10408@garzik.org \
--to=jeff@garzik.org \
--cc=Ramkrishna.Vepa@neterion.com \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).