netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [2.6 patch] net/sctp/: make 2 functions static
@ 2006-12-16 13:57 Adrian Bunk
  2006-12-18  0:40 ` Sridhar Samudrala
  0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2006-12-16 13:57 UTC (permalink / raw)
  To: sri; +Cc: lksctp-developers, linux-kernel, netdev

This patch makes the following needlessly global functions static:
- ipv6.c: sctp_inet6addr_event()
- protocol.c: sctp_inetaddr_event()

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 include/net/sctp/sctp.h |    2 --
 net/sctp/ipv6.c         |    4 ++--
 net/sctp/protocol.c     |    4 ++--
 3 files changed, 4 insertions(+), 6 deletions(-)

--- linux-2.6.20-rc1-mm1/net/sctp/ipv6.c.old	2006-12-16 01:05:15.000000000 +0100
+++ linux-2.6.20-rc1-mm1/net/sctp/ipv6.c	2006-12-16 01:05:40.000000000 +0100
@@ -79,8 +79,8 @@
 #include <asm/uaccess.h>
 
 /* Event handler for inet6 address addition/deletion events.  */
-int sctp_inet6addr_event(struct notifier_block *this, unsigned long ev,
-                        void *ptr)
+static int sctp_inet6addr_event(struct notifier_block *this, unsigned long ev,
+				void *ptr)
 {
 	struct inet6_ifaddr *ifa = (struct inet6_ifaddr *)ptr;
 	struct sctp_sockaddr_entry *addr;
--- linux-2.6.20-rc1-mm1/include/net/sctp/sctp.h.old	2006-12-16 01:05:47.000000000 +0100
+++ linux-2.6.20-rc1-mm1/include/net/sctp/sctp.h	2006-12-16 01:05:53.000000000 +0100
@@ -128,8 +128,6 @@
 				     int flags);
 extern struct sctp_pf *sctp_get_pf_specific(sa_family_t family);
 extern int sctp_register_pf(struct sctp_pf *, sa_family_t);
-int sctp_inetaddr_event(struct notifier_block *this, unsigned long ev,
-                        void *ptr);
 
 /*
  * sctp/socket.c
--- linux-2.6.20-rc1-mm1/net/sctp/protocol.c.old	2006-12-16 01:05:59.000000000 +0100
+++ linux-2.6.20-rc1-mm1/net/sctp/protocol.c	2006-12-16 01:06:07.000000000 +0100
@@ -601,8 +601,8 @@
 }
 
 /* Event handler for inet address addition/deletion events.  */
-int sctp_inetaddr_event(struct notifier_block *this, unsigned long ev,
-                        void *ptr)
+static int sctp_inetaddr_event(struct notifier_block *this, unsigned long ev,
+			       void *ptr)
 {
 	struct in_ifaddr *ifa = (struct in_ifaddr *)ptr;
 	struct sctp_sockaddr_entry *addr;


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [2.6 patch] net/sctp/: make 2 functions static
  2006-12-16 13:57 [2.6 patch] net/sctp/: make 2 functions static Adrian Bunk
@ 2006-12-18  0:40 ` Sridhar Samudrala
  0 siblings, 0 replies; 2+ messages in thread
From: Sridhar Samudrala @ 2006-12-18  0:40 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: lksctp-developers, linux-kernel, netdev

Adrian Bunk wrote:
> This patch makes the following needlessly global functions static:
> - ipv6.c: sctp_inet6addr_event()
> - protocol.c: sctp_inetaddr_event()
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
>   
Acked-by: Sridhar Samudrala <sri@us.ibm.com>

Thanks
Sridhar
> ---
>
>  include/net/sctp/sctp.h |    2 --
>  net/sctp/ipv6.c         |    4 ++--
>  net/sctp/protocol.c     |    4 ++--
>  3 files changed, 4 insertions(+), 6 deletions(-)
>
> --- linux-2.6.20-rc1-mm1/net/sctp/ipv6.c.old	2006-12-16 01:05:15.000000000 +0100
> +++ linux-2.6.20-rc1-mm1/net/sctp/ipv6.c	2006-12-16 01:05:40.000000000 +0100
> @@ -79,8 +79,8 @@
>  #include <asm/uaccess.h>
>
>  /* Event handler for inet6 address addition/deletion events.  */
> -int sctp_inet6addr_event(struct notifier_block *this, unsigned long ev,
> -                        void *ptr)
> +static int sctp_inet6addr_event(struct notifier_block *this, unsigned long ev,
> +				void *ptr)
>  {
>  	struct inet6_ifaddr *ifa = (struct inet6_ifaddr *)ptr;
>  	struct sctp_sockaddr_entry *addr;
> --- linux-2.6.20-rc1-mm1/include/net/sctp/sctp.h.old	2006-12-16 01:05:47.000000000 +0100
> +++ linux-2.6.20-rc1-mm1/include/net/sctp/sctp.h	2006-12-16 01:05:53.000000000 +0100
> @@ -128,8 +128,6 @@
>  				     int flags);
>  extern struct sctp_pf *sctp_get_pf_specific(sa_family_t family);
>  extern int sctp_register_pf(struct sctp_pf *, sa_family_t);
> -int sctp_inetaddr_event(struct notifier_block *this, unsigned long ev,
> -                        void *ptr);
>
>  /*
>   * sctp/socket.c
> --- linux-2.6.20-rc1-mm1/net/sctp/protocol.c.old	2006-12-16 01:05:59.000000000 +0100
> +++ linux-2.6.20-rc1-mm1/net/sctp/protocol.c	2006-12-16 01:06:07.000000000 +0100
> @@ -601,8 +601,8 @@
>  }
>
>  /* Event handler for inet address addition/deletion events.  */
> -int sctp_inetaddr_event(struct notifier_block *this, unsigned long ev,
> -                        void *ptr)
> +static int sctp_inetaddr_event(struct notifier_block *this, unsigned long ev,
> +			       void *ptr)
>  {
>  	struct in_ifaddr *ifa = (struct in_ifaddr *)ptr;
>  	struct sctp_sockaddr_entry *addr;
>
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>   



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-12-18  0:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-16 13:57 [2.6 patch] net/sctp/: make 2 functions static Adrian Bunk
2006-12-18  0:40 ` Sridhar Samudrala

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).