netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Divy Le Ray <divy@chelsio.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: jeff@garzik.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, swise@opengridcomputing.com
Subject: Re: [PATCH 4/10] cxgb3 - HW access routines - part 2
Date: Wed, 20 Dec 2006 15:00:24 -0800	[thread overview]
Message-ID: <4589C088.7020107@chelsio.com> (raw)
In-Reply-To: <1166623459.3365.1399.camel@laptopd505.fenrus.org>

Arjan van de Ven wrote:
>> +void t3_port_intr_disable(struct adapter *adapter, int idx)
>> +{
>> +	struct cphy *phy = &adap2pinfo(adapter, idx)->phy;
>> +
>> +	t3_write_reg(adapter, XGM_REG(A_XGM_INT_ENABLE, idx), 0);
>> +	phy->ops->intr_disable(phy);
>>     
>
> you seem to be missing a pci posting flush here....
>   
Thanks for catching this. Will fix.

  reply	other threads:[~2006-12-20 23:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-20 12:42 [PATCH 4/10] cxgb3 - HW access routines - part 2 divy
2006-12-20 14:04 ` Arjan van de Ven
2006-12-20 23:00   ` Divy Le Ray [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-12-22  7:20 divy
2006-12-14  5:42 divy
2006-12-08  3:26 divy
2006-12-04 19:45 divy
2006-12-04 20:06 ` Divy Le Ray
2006-11-17 20:25 divy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4589C088.7020107@chelsio.com \
    --to=divy@chelsio.com \
    --cc=arjan@infradead.org \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=swise@opengridcomputing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).