From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keiichi KII Subject: [RFC][PATCH 2.6.19 take2 1/5] marking __init and remove drop initialization Date: Thu, 21 Dec 2006 19:03:23 +0900 Message-ID: <458A5BEB.8090400@bx.jp.nec.com> References: <458A5AAE.30209@bx.jp.nec.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Return-path: Received: from TYO202.gate.nec.co.jp ([202.32.8.206]:60203 "EHLO tyo202.gate.nec.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422932AbWLUKD3 (ORCPT ); Thu, 21 Dec 2006 05:03:29 -0500 To: mpm@selenic.com In-Reply-To: <458A5AAE.30209@bx.jp.nec.com> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Keiichi KII This patch contains the following cleanups. - add __init for initialization functions(option_setup() and init_netconsole()). - remove "drop" initialization in the netpoll structure. Signed-off-by: Keiichi KII --- [changes] 1. stop to use anoymous enum. 2. remove unrelated changes(formatting changes). --- linux-2.6.19/drivers/net/netconsole.c 2006-12-21 18:26:04.017895000 +0900 +++ enhanced-netconsole/drivers/net/netconsole.c.cleanup 2006-12-21 18:38:34.080771000 +0900 @@ -60,7 +60,6 @@ static struct netpoll np = { .local_port = 6665, .remote_port = 6666, .remote_mac = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff}, - .drop = netpoll_queue, }; static int configured = 0; @@ -92,7 +91,7 @@ static struct console netconsole = { .write = write_msg }; -static int option_setup(char *opt) +static int __init option_setup(char *opt) { configured = !netpoll_parse_options(&np, opt); return 1; @@ -100,7 +99,7 @@ static int option_setup(char *opt) __setup("netconsole=", option_setup); -static int init_netconsole(void) +static int __init init_netconsole(void) { if(strlen(config)) option_setup(config); -- Keiichi KII NEC Corporation OSS Promotion Center E-mail: k-keiichi@bx.jp.nec.com